RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 09:44:57 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Stop generating is_foo_wrapper() for JS DOM wrappers

Browse source
This commit is contained in:
Andreas Kling 2021-01-01 18:06:38 +01:00
parent f48751a739
commit d2613403e0
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibJS/Runtime/Object.h
View file

@ -112,7 +112,6 @@ public:
virtual bool is_array() const { return false; } virtual bool is_array() const { return false; }
virtual bool is_function() const { return false; } virtual bool is_function() const { return false; }
virtual bool is_typed_array() const { return false; } virtual bool is_typed_array() const { return false; }
virtual bool is_node_wrapper() const { return false; }
virtual const char* class_name() const override { return "Object"; } virtual const char* class_name() const override { return "Object"; }
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;

4
Libraries/LibWeb/Bindings/RangePrototype.cpp
View file

@ -80,7 +80,7 @@ JS_DEFINE_NATIVE_FUNCTION(RangePrototype::set_start)
if (vm.exception()) if (vm.exception())
return {}; return {};
if (!arg0->is_node_wrapper()) { if (!is<NodeWrapper>(arg0)) {
vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "Node"); vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "Node");
return {}; return {};
} }
@ -103,7 +103,7 @@ JS_DEFINE_NATIVE_FUNCTION(RangePrototype::set_end)
if (vm.exception()) if (vm.exception())
return {}; return {};
if (!arg0->is_node_wrapper()) { if (!is<NodeWrapper>(arg0)) {
vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "Node"); vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotA, "Node");
return {}; return {};
} }

1
Libraries/LibWeb/CodeGenerators/WrapperGenerator.cpp
View file

@ -480,7 +480,6 @@ public:
generator.append(R"~~~( generator.append(R"~~~(
private: private:
virtual bool is_@wrapper_class:snakecase@() const final { return true; }
)~~~"); )~~~");
for (auto& function : interface.functions) { for (auto& function : interface.functions) {