RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:07:43 +00:00
Code Issues Activity Actions

PixelPaint: Set Tool on_*_color_change logic using virtual functions

Browse source 
Previously, we were rewriting the on_primary_color_change in the Text
Tool and Gradient, which made the palette widget no longer update after
picking a color from an image. Additionally, it also crashed the program
after leaving the Gradient tool and trying to change color.
This commit is contained in:
Karol Kosek 2023-02-13 18:42:45 +01:00 • committed by Sam Atkins
parent cb96c892cc
commit d27d19f012
7 changed files with 23 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/PixelPaint/Tools/TextTool.cpp
View file

@ -41,11 +41,9 @@ TextTool::TextTool()
}).release_value_but_fixme_should_propagate_errors();
}
void TextTool::on_tool_activation()
void TextTool::on_primary_color_change(Color color)
{
m_editor->on_primary_color_change = [this](auto color) {
m_text_color = color;
};
m_text_color = color;
}
void TextTool::on_tool_deactivation()