RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

LanguageServers/Cpp: Make token_in_position() return a StringView

Browse source 
This avoids a whole bunch of string allocation churn.
This commit is contained in:
Andreas Kling 2020-10-29 22:49:14 +01:00
parent aaf4ec62cf
commit d28127c807
2 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
DevTools/HackStudio/LanguageServers/Cpp/AutoComplete.cpp
View file

@ -53,9 +53,11 @@ Vector<AutoCompleteResponse> AutoComplete::get_suggestions(const String& code, c
return suggestions; return suggestions;
} }
String AutoComplete::text_of_token(const Vector<String>& lines, const Cpp::Token& token) StringView AutoComplete::text_of_token(const Vector<String>& lines, const Cpp::Token& token)
{ {
return lines[token.m_start.line].substring(token.m_start.column, token.m_end.column - token.m_start.column + 1); ASSERT(token.m_start.line == token.m_end.line);
ASSERT(token.m_start.column <= token.m_end.column);
return lines[token.m_start.line].substring_view(token.m_start.column, token.m_end.column - token.m_start.column + 1);
} }
Optional<size_t> AutoComplete::token_in_position(const Vector<Cpp::Token>& tokens, const GUI::TextPosition& position) Optional<size_t> AutoComplete::token_in_position(const Vector<Cpp::Token>& tokens, const GUI::TextPosition& position)
@ -83,8 +85,7 @@ Vector<AutoCompleteResponse> AutoComplete::identifier_prefixes(const Vector<Stri
if (token.m_type != Cpp::Token::Type::Identifier) if (token.m_type != Cpp::Token::Type::Identifier)
continue; continue;
auto text = text_of_token(lines, token); auto text = text_of_token(lines, token);
if (text.starts_with(partial_input) && !suggestions_lookup.contains(text)) { if (text.starts_with(partial_input) && suggestions_lookup.set(text) == AK::HashSetResult::InsertedNewEntry) {
suggestions_lookup.set(text);
suggestions.append({ text, partial_input.length(), HackStudio::CompletionKind::Identifier }); suggestions.append({ text, partial_input.length(), HackStudio::CompletionKind::Identifier });
} }
} }

2
DevTools/HackStudio/LanguageServers/Cpp/AutoComplete.h
View file

@ -45,7 +45,7 @@ public:
private: private:
static Optional<size_t> token_in_position(const Vector<Cpp::Token>&, const GUI::TextPosition&); static Optional<size_t> token_in_position(const Vector<Cpp::Token>&, const GUI::TextPosition&);
static String text_of_token(const Vector<String>& lines, const Cpp::Token&); static StringView text_of_token(const Vector<String>& lines, const Cpp::Token&);
static Vector<AutoCompleteResponse> identifier_prefixes(const Vector<String>& lines, const Vector<Cpp::Token>&, size_t target_token_index); static Vector<AutoCompleteResponse> identifier_prefixes(const Vector<String>& lines, const Vector<Cpp::Token>&, size_t target_token_index);
}; };