From d29d9462e9c34ff89990073deb7d7fadb66b1779 Mon Sep 17 00:00:00 2001 From: Max Wipfli Date: Mon, 21 Feb 2022 17:34:19 +0100 Subject: [PATCH] AK: Suppress clang-tidy warning on TODO() This adds a NOLINT directive to the definition of the TODO() macro. clang-tidy wants the assert replaced with a static_assert, since the macro simply resolves to assert(false). This is obviously nonsensical, since we want the code to still compile even with TODO(). The same fix has already been implemented for VERIFY_NOT_REACHED(). --- AK/Assertions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AK/Assertions.h b/AK/Assertions.h index cb28d8f7f4..55e7c989da 100644 --- a/AK/Assertions.h +++ b/AK/Assertions.h @@ -13,5 +13,5 @@ # define VERIFY assert # define VERIFY_NOT_REACHED() assert(false) /* NOLINT(cert-dcl03-c,misc-static-assert) No, this can't be static_assert, it's a runtime check */ static constexpr bool TODO = false; -# define TODO() VERIFY(TODO) +# define TODO() VERIFY(TODO) /* NOLINT(cert-dcl03-c,misc-static-assert) No, this can't be static_assert, it's a runtime check */ #endif