RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 12:45:08 +00:00
Code Issues Activity Actions

LibWeb: Convert usages of type() to type_state()

Browse source 
This doesn't have any performance benefit yet as we still do string
comparisons everytime, but it should improve once type_state() has a
better implementation.
This commit is contained in:
sin-ack 2022-03-15 12:14:54 +00:00 • committed by Andreas Kling
parent 57a85b1017
commit d2a99eded7
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -39,16 +39,16 @@ HTMLInputElement::~HTMLInputElement()
RefPtr<Layout::Node> HTMLInputElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style) RefPtr<Layout::Node> HTMLInputElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)
{ {
if (type() == "hidden") if (type_state() == TypeAttributeState::Hidden)
return nullptr; return nullptr;
if (type() == "submit" || type() == "button" || type() == "reset") if (type_state() == TypeAttributeState::SubmitButton || type_state() == TypeAttributeState::Button || type_state() == TypeAttributeState::ResetButton)
return adopt_ref(*new Layout::ButtonBox(document(), *this, move(style))); return adopt_ref(*new Layout::ButtonBox(document(), *this, move(style)));
if (type() == "checkbox") if (type_state() == TypeAttributeState::Checkbox)
return adopt_ref(*new Layout::CheckBox(document(), *this, move(style))); return adopt_ref(*new Layout::CheckBox(document(), *this, move(style)));
if (type() == "radio") if (type_state() == TypeAttributeState::RadioButton)
return adopt_ref(*new Layout::RadioButton(document(), *this, move(style))); return adopt_ref(*new Layout::RadioButton(document(), *this, move(style)));
auto layout_node = adopt_ref(*new Layout::BlockContainer(document(), this, move(style))); auto layout_node = adopt_ref(*new Layout::BlockContainer(document(), this, move(style)));
@ -72,7 +72,7 @@ void HTMLInputElement::set_checked(bool checked, ChangeSource change_source)
void HTMLInputElement::set_checked_binding(bool checked) void HTMLInputElement::set_checked_binding(bool checked)
{ {
if (type() == "radio") { if (type_state() == TypeAttributeState::RadioButton) {
if (checked) if (checked)
set_checked_within_group(); set_checked_within_group();
else else
@ -85,7 +85,7 @@ void HTMLInputElement::set_checked_binding(bool checked)
// https://html.spec.whatwg.org/multipage/input.html#input-activation-behavior // https://html.spec.whatwg.org/multipage/input.html#input-activation-behavior
void HTMLInputElement::run_input_activation_behavior() void HTMLInputElement::run_input_activation_behavior()
{ {
if (type() == "checkbox" || type() == "radio") { if (type_state() == TypeAttributeState::Checkbox || type_state() == TypeAttributeState::RadioButton) {
// 1. If the element is not connected, then return. // 1. If the element is not connected, then return.
if (!is_connected()) if (!is_connected())
return; return;
@ -100,7 +100,7 @@ void HTMLInputElement::run_input_activation_behavior()
auto change_event = DOM::Event::create(HTML::EventNames::change); auto change_event = DOM::Event::create(HTML::EventNames::change);
change_event->set_bubbles(true); change_event->set_bubbles(true);
dispatch_event(move(change_event)); dispatch_event(move(change_event));
} else if (type() == "submit") { } else if (type_state() == TypeAttributeState::SubmitButton) {
RefPtr<HTMLFormElement> form; RefPtr<HTMLFormElement> form;
// 1. If the element does not have a form owner, then return. // 1. If the element does not have a form owner, then return.
if (!(form = this->form())) if (!(form = this->form()))