RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:37:36 +00:00
Code Issues Activity Actions

LibWeb: Only create one wrapper for inline content inside flex container

Browse source 
Due to a missing `return` statement, we were creating two anonymous
wrapper blocks around each piece of inline content inside a flex
container.

This had no visual impact, since they ended up with 0x0 dimensions,
but we were wasting a fair bit of time running layout on them.
This commit is contained in:
Andreas Kling 2022-07-13 01:18:59 +02:00
parent a1ddc44c07
commit d2b887a793
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp
View file

@ -60,6 +60,7 @@ static Layout::Node& insertion_parent_for_inline_node(Layout::NodeWithStyle& lay
if (layout_parent.computed_values().display().is_flex_inside()) { if (layout_parent.computed_values().display().is_flex_inside()) {
layout_parent.append_child(layout_parent.create_anonymous_wrapper()); layout_parent.append_child(layout_parent.create_anonymous_wrapper());
return *layout_parent.last_child();
} }
if (!has_in_flow_block_children(layout_parent) || layout_parent.children_are_inline()) if (!has_in_flow_block_children(layout_parent) || layout_parent.children_are_inline())