From d2c3749cf3269d28726589b7c077d824dd97b1dd Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 18 May 2019 17:31:52 +0200 Subject: [PATCH] Kernel: Don't allow dump_backtrace() to call dump_backtrace(). That was not a very graceful looking loop to be stuck in. --- Kernel/KSyms.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Kernel/KSyms.cpp b/Kernel/KSyms.cpp index 38719cd1bb..876c2d538b 100644 --- a/Kernel/KSyms.cpp +++ b/Kernel/KSyms.cpp @@ -3,6 +3,7 @@ #include "Scheduler.h" #include #include +#include static KSym* s_ksyms; dword ksym_lowest_address; @@ -132,6 +133,12 @@ static void load_ksyms_from_data(const ByteBuffer& buffer) void dump_backtrace() { + static bool in_dump_backtrace = false; + if (in_dump_backtrace) { + dbgprintf("dump_backtrace() called from within itself, what the hell is going on!\n"); + return; + } + TemporaryChange change(in_dump_backtrace, true); dword ebp; asm volatile("movl %%ebp, %%eax":"=a"(ebp)); dump_backtrace_impl(ebp, ksyms_ready);