RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:07:35 +00:00
Code Issues Activity Actions

LibJS: Use IndexedProperties::for_each_value() in update_function_name()

Browse source 
This allows us to get rid of IndexedProperties::values_unordered().
This commit is contained in:
Andreas Kling 2020-12-08 15:08:49 +01:00
parent 6c4b823cef
commit d2e3e038d6
3 changed files with 5 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibJS/Runtime/IndexedProperties.cpp
View file

@ -387,24 +387,6 @@ Vector<u32> IndexedProperties::indices() const
return indices;
}
Vector<ValueAndAttributes> IndexedProperties::values_unordered() const
{
if (m_storage->is_simple_storage()) {
const auto& elements = static_cast<const SimpleIndexedPropertyStorage&>(*m_storage).elements();
Vector<ValueAndAttributes> with_attributes;
for (auto& value : elements)
with_attributes.append({ value, default_attributes });
return with_attributes;
}
auto& storage = static_cast<const GenericIndexedPropertyStorage&>(*m_storage);
auto values = storage.packed_elements();
values.ensure_capacity(values.size() + storage.sparse_elements().size());
for (auto& entry : storage.sparse_elements())
values.unchecked_append(entry.value);
return values;
}
void IndexedProperties::switch_to_generic_storage()
{
auto& storage = static_cast<SimpleIndexedPropertyStorage&>(*m_storage);