RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

LibWeb: Set min-width for inline child boxes after inside layout

Browse source 
min-width for boxes with inline children can only be applied after
inside layout is done and width of box content is known.
This commit is contained in:
Aliaksandr Kalenik 2023-08-02 14:46:45 +03:00 • committed by Andreas Kling
parent 50bf303edd
commit d32bf4cd41
3 changed files with 42 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -510,14 +510,33 @@ void BlockFormattingContext::layout_inline_children(BlockContainer const& block_
available_space);
if (!block_container_state.has_definite_width()) {
// NOTE: max-width for boxes with inline children can only be applied after inside layout is done
// and width of box content is known
// NOTE: min-width or max-width for boxes with inline children can only be applied after inside layout
// is done and width of box content is known
auto used_width_px = context.automatic_content_width();
if (!should_treat_max_width_as_none(block_container, available_space.width)) {
auto max_width_px = calculate_inner_width(block_container, available_space.width, block_container.computed_values().max_width()).to_px(block_container);
if (used_width_px > max_width_px)
used_width_px = max_width_px;
}
auto should_treat_min_width_as_auto = [&] {
auto const& available_width = available_space.width;
auto const& min_width = block_container.computed_values().min_width();
if (min_width.is_auto())
return true;
if (min_width.is_fit_content() && available_width.is_intrinsic_sizing_constraint())
return true;
if (min_width.is_max_content() && available_width.is_max_content())
return true;
if (min_width.is_min_content() && available_width.is_min_content())
return true;
return false;
}();
if (!should_treat_min_width_as_auto) {
auto min_width_px = calculate_inner_width(block_container, available_space.width, block_container.computed_values().min_width()).to_px(block_container);
if (used_width_px < min_width_px)
used_width_px = min_width_px;
}
block_container_state.set_content_width(used_width_px);
}
if (!block_container_state.has_definite_height())