From d347432a9e41f33f6067e497a5b84a4d3a542db7 Mon Sep 17 00:00:00 2001
From: Brian Gianforcaro <bgianf@serenityos.org>
Date: Sat, 9 Oct 2021 23:53:47 -0700
Subject: [PATCH] LibELF: Use member initialization for
 AuxiliaryVector::optional_string

When the member is initialized in the constructor body, but also has a
default constructor, you pay for default construction to just throw it
away. In this case a StringView is light weight to initialize, but we
might as well fix all cases we find.

Found by PVS-Studio: https://pvs-studio.com/en/docs/warnings/v818/
---
 Userland/Libraries/LibELF/AuxiliaryVector.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Userland/Libraries/LibELF/AuxiliaryVector.h b/Userland/Libraries/LibELF/AuxiliaryVector.h
index f41d99e53d..0804914cb7 100644
--- a/Userland/Libraries/LibELF/AuxiliaryVector.h
+++ b/Userland/Libraries/LibELF/AuxiliaryVector.h
@@ -90,10 +90,10 @@ struct AuxiliaryValue {
         auxv.a_un.a_ptr = (void*)ptr;
     }
     AuxiliaryValue(Type type, StringView string)
+        : optional_string(string)
     {
         auxv.a_type = type;
         auxv.a_un.a_ptr = nullptr;
-        optional_string = string;
     }
 
     auxv_t auxv {};