RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:47:45 +00:00
Code Issues Activity Actions

Terminal+HackStudio: Fix leaking PTM fd to child processes

Browse source 
The pseudoterminal *master* fd is not supposed to be inherited,
so make sure to open it with O_CLOEXEC.
This commit is contained in:
Sergey Bugaev 2019-11-13 16:04:31 +03:00 • committed by Andreas Kling
parent bf012ca10a
commit d3504b4f9b
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
DevTools/HackStudio/TerminalWrapper.cpp
View file

@ -24,7 +24,7 @@ void TerminalWrapper::run_command(const String& command)
return;
}
int ptm_fd = open("/dev/ptmx", O_RDWR);
int ptm_fd = open("/dev/ptmx", O_RDWR | O_CLOEXEC);
if (ptm_fd < 0) {
perror("open(ptmx)");
ASSERT_NOT_REACHED();