From d350d2dfcea2f14fa73c46b4f91f26f00e4ad325 Mon Sep 17 00:00:00 2001 From: Tim Schumacher Date: Fri, 5 Nov 2021 20:56:37 +0100 Subject: [PATCH] Emulator: Restrict library name check when querying symbols Libraries in /usr/lib currently only end in .so, so no contains() is needed for now. --- Userland/DevTools/UserspaceEmulator/Emulator.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/DevTools/UserspaceEmulator/Emulator.cpp b/Userland/DevTools/UserspaceEmulator/Emulator.cpp index 394c56e338..c888367df7 100644 --- a/Userland/DevTools/UserspaceEmulator/Emulator.cpp +++ b/Userland/DevTools/UserspaceEmulator/Emulator.cpp @@ -432,7 +432,7 @@ Optional Emulator::symbol_at(FlatPtr address) auto lib_name = address_region->lib_name(); auto const* first_region = (lib_name.is_null() || lib_name.is_empty()) ? address_region : first_region_for_object(lib_name); VERIFY(first_region); - auto lib_path = lib_name.contains(".so"sv) ? String::formatted("/usr/lib/{}", lib_name) : lib_name; + auto lib_path = lib_name.ends_with(".so"sv) ? String::formatted("/usr/lib/{}", lib_name) : lib_name; auto it = m_dynamic_library_cache.find(lib_path); auto const& elf = it->value.debug_info->elf();