RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibWeb: Make DOMImplementation forward its ref count to DOM::Document

Browse source 
This allows document.implementation to keep the underlying document
alive for as long as we need it (for example, if someone holds on to a
DOMImplementation JS wrapper after the document is GC'd.)
This commit is contained in:
Andreas Kling 2021-12-09 12:51:05 +01:00
parent e1287a9a45
commit d368b08698
4 changed files with 22 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/DOM/DOMImplementation.h
View file

@ -7,28 +7,30 @@
#pragma once
#include <AK/NonnullRefPtr.h>
#include <AK/RefCountForwarder.h>
#include <AK/RefCounted.h>
#include <AK/Weakable.h>
#include <LibWeb/Bindings/Wrappable.h>
#include <LibWeb/DOM/Document.h>
namespace Web::DOM {
class DOMImplementation final
: public RefCounted<DOMImplementation>
: public RefCountForwarder<Document>
, public Weakable<DOMImplementation>
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::DOMImplementationWrapper;
static NonnullRefPtr<DOMImplementation> create(Document& document)
static NonnullOwnPtr<DOMImplementation> create(Badge<Document>, Document& document)
{
return adopt_ref(*new DOMImplementation(document));
return adopt_own(*new DOMImplementation(document));
}
// FIXME: Add optional DocumentType once supported by IDL
NonnullRefPtr<Document> create_document(const String&, const String&) const;
NonnullRefPtr<Document> create_html_document(const String& title) const;
NonnullRefPtr<DocumentType> create_document_type(const String&, const String&, const String&) const;
NonnullRefPtr<DocumentType> create_document_type(String const& qualified_name, String const& public_id, String const& system_id);
// https://dom.spec.whatwg.org/#dom-domimplementation-hasfeature
bool has_feature() const { return true; }
@ -36,7 +38,8 @@ public:
private:
explicit DOMImplementation(Document&);
Document& m_document;
Document& document() { return ref_count_target(); }
Document const& document() const { return ref_count_target(); }
};
}