RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:47:34 +00:00
Code Issues Activity Actions

LibWeb: Verify that the Tokenizer doesn't produce Dimensions from %

Browse source 
If `12.34%` ever produces a Dimension token instead of a Percentage,
then something has gone wrong and we want to know about it!
This commit is contained in:
Sam Atkins 2021-11-18 11:54:32 +00:00 • committed by Andreas Kling
parent 522faa1554
commit d37f62fd54
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -1905,9 +1905,7 @@ Optional<Length> Parser::parse_length(StyleComponentValueRule const& component_v
numeric_value = component_value.token().dimension_value(); numeric_value = component_value.token().dimension_value();
auto unit_string = component_value.token().m_unit.string_view(); auto unit_string = component_value.token().m_unit.string_view();
if (unit_string.equals_ignoring_case("%")) { if (unit_string.equals_ignoring_case("px")) {
type = Length::Type::Percentage;
} else if (unit_string.equals_ignoring_case("px")) {
type = Length::Type::Px; type = Length::Type::Px;
} else if (unit_string.equals_ignoring_case("pt")) { } else if (unit_string.equals_ignoring_case("pt")) {
type = Length::Type::Pt; type = Length::Type::Pt;
@ -1937,6 +1935,9 @@ Optional<Length> Parser::parse_length(StyleComponentValueRule const& component_v
type = Length::Type::In; type = Length::Type::In;
} else if (unit_string.equals_ignoring_case("Q")) { } else if (unit_string.equals_ignoring_case("Q")) {
type = Length::Type::Q; type = Length::Type::Q;
} else if (unit_string.equals_ignoring_case("%")) {
// A number followed by `%` must always result in a Percentage token.
VERIFY_NOT_REACHED();
} else { } else {
return {}; return {};
} }