From d385adf6bd1ddb55b87e83699f342bf3624c3eb5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= <filmroellchen@serenityos.org>
Date: Sat, 18 Feb 2023 12:11:56 +0100
Subject: [PATCH] LibGUI: Don't silently create a 0 UIDimension when the JSON
 is invalid

The function already can report an invalid JSON value for the dimension,
so let's actually use that for when the number is too large or some
other invalid JSON type, like an object or a boolean, was passed.
---
 Userland/Libraries/LibGUI/UIDimensions.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Userland/Libraries/LibGUI/UIDimensions.h b/Userland/Libraries/LibGUI/UIDimensions.h
index 6c40d006cd..30cfbe6d56 100644
--- a/Userland/Libraries/LibGUI/UIDimensions.h
+++ b/Userland/Libraries/LibGUI/UIDimensions.h
@@ -162,12 +162,13 @@ public:
                 return UIDimension { SpecialDimension::Fit };
             else
                 return {};
-        } else {
-            int value_int = value.to_i32();
+        } else if (value.is_integer<i32>()) {
+            auto value_int = value.as_integer<i32>();
             if (value_int < 0)
                 return {};
             return UIDimension(value_int);
         }
+        return {};
     }
 
 private: