RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:17:34 +00:00
Code Issues Activity Actions

Kernel/PCI: Rename Access::scan_pci_domains method

Browse source 
We rename it to scan_pci_domains_from_acpi_mcfg_table to ensure clarity,
because this method relies on the ACPI MCFG table to work.
This commit is contained in:
Liav A 2021-10-22 19:54:20 +03:00 • committed by Andreas Kling
parent ca32ee5714
commit d395ac8f59
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Bus/PCI/Access.cpp
View file

@ -42,14 +42,14 @@ UNMAP_AFTER_INIT bool Access::initialize_for_memory_access(PhysicalAddress mcfg_
InterruptDisabler disabler; InterruptDisabler disabler;
auto* access = new Access(Access::AccessType::Memory); auto* access = new Access(Access::AccessType::Memory);
if (!access->scan_pci_domains(mcfg_table)) if (!access->search_pci_domains_from_acpi_mcfg_table(mcfg_table))
return false; return false;
access->rescan_hardware(); access->rescan_hardware();
dbgln_if(PCI_DEBUG, "PCI: MMIO access initialised."); dbgln_if(PCI_DEBUG, "PCI: MMIO access initialised.");
return true; return true;
} }
UNMAP_AFTER_INIT bool Access::scan_pci_domains(PhysicalAddress mcfg_table) UNMAP_AFTER_INIT bool Access::search_pci_domains_from_acpi_mcfg_table(PhysicalAddress mcfg_table)
{ {
auto checkup_region_or_error = MM.allocate_kernel_region(mcfg_table.page_base(), (PAGE_SIZE * 2), "PCI MCFG Checkup", Memory::Region::Access::ReadWrite); auto checkup_region_or_error = MM.allocate_kernel_region(mcfg_table.page_base(), (PAGE_SIZE * 2), "PCI MCFG Checkup", Memory::Region::Access::ReadWrite);
if (checkup_region_or_error.is_error()) if (checkup_region_or_error.is_error())

2
Kernel/Bus/PCI/Access.h
View file

@ -48,7 +48,7 @@ private:
void enumerate_device(int type, u8 bus, u8 device, bool recursive); void enumerate_device(int type, u8 bus, u8 device, bool recursive);
explicit Access(AccessType); explicit Access(AccessType);
bool scan_pci_domains(PhysicalAddress mcfg); bool search_pci_domains_from_acpi_mcfg_table(PhysicalAddress mcfg);
Vector<Capability> get_capabilities(Address); Vector<Capability> get_capabilities(Address);
Optional<u8> get_capabilities_pointer(Address address); Optional<u8> get_capabilities_pointer(Address address);