From d3a80b1a6e66ed1d142eea06fc873861c1497039 Mon Sep 17 00:00:00 2001
From: Rok Povsic <rok.povsic@gmail.com>
Date: Sun, 19 Dec 2021 13:55:54 +0100
Subject: [PATCH] Profiler: Extract the bar label String into a private method

---
 Userland/DevTools/Profiler/FlameGraphView.cpp | 16 +++++++++++-----
 Userland/DevTools/Profiler/FlameGraphView.h   |  1 +
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/Userland/DevTools/Profiler/FlameGraphView.cpp b/Userland/DevTools/Profiler/FlameGraphView.cpp
index 76fcffeb9c..c2dcbdc36f 100644
--- a/Userland/DevTools/Profiler/FlameGraphView.cpp
+++ b/Userland/DevTools/Profiler/FlameGraphView.cpp
@@ -116,11 +116,7 @@ void FlameGraphView::paint_event(GUI::PaintEvent& event)
     painter.add_clip_rect(event.rect());
 
     for (const auto& bar : m_bars) {
-        auto label_index = bar.index.sibling_at_column(m_text_column);
-        String label = "All";
-        if (label_index.is_valid()) {
-            label = m_model.data(label_index).to_string();
-        }
+        auto label = bar_label(bar);
 
         auto color = m_colors[label.hash() % m_colors.size()];
 
@@ -148,6 +144,16 @@ void FlameGraphView::paint_event(GUI::PaintEvent& event)
     }
 }
 
+String FlameGraphView::bar_label(StackBar const& bar) const
+{
+    auto label_index = bar.index.sibling_at_column(m_text_column);
+    String label = "All";
+    if (label_index.is_valid()) {
+        label = m_model.data(label_index).to_string();
+    }
+    return label;
+}
+
 void FlameGraphView::layout_bars()
 {
     m_bars.clear();
diff --git a/Userland/DevTools/Profiler/FlameGraphView.h b/Userland/DevTools/Profiler/FlameGraphView.h
index 881738cf20..cff5837def 100644
--- a/Userland/DevTools/Profiler/FlameGraphView.h
+++ b/Userland/DevTools/Profiler/FlameGraphView.h
@@ -45,6 +45,7 @@ private:
         bool selected;
     };
 
+    String bar_label(StackBar const&) const;
     void layout_bars();
     void layout_children(GUI::ModelIndex& parent, int depth, int left, int right, Vector<GUI::ModelIndex>& selected);