From d3a8ee6e4b24966dff4874a84c09f8b67f353fab Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Tue, 22 Aug 2023 23:31:11 -0600 Subject: [PATCH] LibWeb: Remove unused SessionHistoryEntry::serialized_state We never implemented this for History::pushState/popState, and now that we're working on the Navigable changes, we don't need this legacy entry with its legacy name. --- Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp | 2 -- Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp b/Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp index 14cb47f463..1bf4ec8617 100644 --- a/Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp +++ b/Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp @@ -242,7 +242,6 @@ JS::NonnullGCPtr BrowsingContext::create_a_new_browsing_context auto new_entry = browsing_context->heap().allocate_without_realm(); new_entry->url = AK::URL("about:blank"); new_entry->document = document.ptr(); - new_entry->serialized_state = {}; new_entry->policy_container = {}; new_entry->scroll_restoration_mode = {}; new_entry->browsing_context_name = {}; @@ -1244,7 +1243,6 @@ WebIDL::ExceptionOr BrowsingContext::navigate_to_a_fragment(AK::URL const& auto new_entry = heap().allocate_without_realm(); new_entry->url = url; new_entry->document = current_entry().document; - new_entry->serialized_state = {}; new_entry->policy_container = current_entry().policy_container; new_entry->scroll_restoration_mode = current_entry().scroll_restoration_mode; new_entry->browsing_context_name = {}; diff --git a/Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h b/Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h index d30b4df6e5..8ef65a8628 100644 --- a/Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h +++ b/Userland/Libraries/LibWeb/HTML/SessionHistoryEntry.h @@ -50,10 +50,6 @@ struct SessionHistoryEntry final : public JS::Cell { // https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-document-state JS::GCPtr document_state; - // https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-serialized-state - // serialized state, which is serialized state, initially StructuredSerializeForStorage(null). - Optional serialized_state; - // https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-scroll-restoration-mode // scroll restoration mode, a scroll restoration mode, initially "auto" ScrollRestorationMode scroll_restoration_mode { ScrollRestorationMode::Auto };