From d3d2e56a68928db28e4a30f9de2a11c94f4b4e31 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Sun, 3 Sep 2023 17:42:00 +0200 Subject: [PATCH] LibWeb: Call `set_ongoing_navigation()` on navigable instead of `this` This fixes incorrectly implemented spec when `set_ongoing_navigation()` is called on `this` (=traversable) instead of `navigable` variable. --- Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp b/Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp index 690ac14f97..bcb8f73a68 100644 --- a/Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp +++ b/Userland/Libraries/LibWeb/HTML/TraversableNavigable.cpp @@ -256,7 +256,7 @@ void TraversableNavigable::apply_the_history_step(int step, Optionalset_current_session_history_entry(target_entry); // 3. Set navigable's ongoing navigation to "traversal". - set_ongoing_navigation(Traversal::Tag); + navigable->set_ongoing_navigation(Traversal::Tag); } // 9. Let totalChangeJobs be the size of changingNavigables. @@ -390,7 +390,7 @@ void TraversableNavigable::apply_the_history_step(int step, Optionalset_ongoing_navigation({}); // 8. Let (scriptHistoryLength, scriptHistoryIndex) be the result of getting the history object length and index given traversable and targetStep. auto [script_history_length, script_history_index] = get_the_history_object_length_and_index(target_step);