RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:17:44 +00:00
Code Issues Activity Actions

AK: Fix StringUtils::contains() case insensitive search

Browse source 
It would incorrectly return false if needle was at the end the string.
This commit is contained in:
Linus Groh 2020-11-12 23:44:32 +00:00 • committed by Andreas Kling
parent b1754bf8f8
commit d3ee3fc68a
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/Tests/TestStringUtils.cpp
View file

@ -203,6 +203,8 @@ TEST_CASE(contains)
EXPECT(AK::StringUtils::contains(test_string, "BCX", CaseSensitivity::CaseSensitive));
EXPECT(AK::StringUtils::contains(test_string, "BCX", CaseSensitivity::CaseInsensitive));
EXPECT(AK::StringUtils::contains(test_string, "BcX", CaseSensitivity::CaseInsensitive));
EXPECT(!AK::StringUtils::contains(test_string, "xyz", CaseSensitivity::CaseSensitive));
EXPECT(AK::StringUtils::contains(test_string, "xyz", CaseSensitivity::CaseInsensitive));
EXPECT(!AK::StringUtils::contains(test_string, "EFG", CaseSensitivity::CaseSensitive));
EXPECT(!AK::StringUtils::contains(test_string, "EfG", CaseSensitivity::CaseInsensitive));
EXPECT(AK::StringUtils::contains(test_string, "", CaseSensitivity::CaseSensitive));