RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:17:35 +00:00
Code Issues Activity Actions

LibGfx: Save spectral information in the context

Browse source 
These variables are useless for baseline JPEG, but they will become
useful for other encodings.
This commit is contained in:
Lucas CHOLLET 2023-02-21 00:56:42 -05:00 • committed by Andreas Kling
parent 3a8c52cabc
commit d421967394
1 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibGfx/JPEGLoader.cpp
View file

@ -194,6 +194,9 @@ struct JPEGLoadingContext {
StartOfFrame frame; StartOfFrame frame;
u8 hsample_factor { 0 }; u8 hsample_factor { 0 };
u8 vsample_factor { 0 }; u8 vsample_factor { 0 };
u8 spectral_selection_start {};
u8 spectral_selection_end {};
u8 successive_approximation {};
Vector<ComponentSpec, 3> components; Vector<ComponentSpec, 3> components;
RefPtr<Gfx::Bitmap> bitmap; RefPtr<Gfx::Bitmap> bitmap;
u16 dc_restart_interval { 0 }; u16 dc_restart_interval { 0 };
@ -565,17 +568,17 @@ static ErrorOr<void> read_start_of_scan(AK::SeekableStream& stream, JPEGLoadingC
} }
} }
u8 spectral_selection_start = TRY(stream.read_value<u8>()); context.spectral_selection_start = TRY(stream.read_value<u8>());
u8 spectral_selection_end = TRY(stream.read_value<u8>()); context.spectral_selection_end = TRY(stream.read_value<u8>());
u8 successive_approximation = TRY(stream.read_value<u8>()); context.successive_approximation = TRY(stream.read_value<u8>());
// The three values should be fixed for baseline JPEGs utilizing sequential DCT. // The three values should be fixed for baseline JPEGs utilizing sequential DCT.
if (spectral_selection_start != 0 || spectral_selection_end != 63 || successive_approximation != 0) { if (context.spectral_selection_start != 0 || context.spectral_selection_end != 63 || context.successive_approximation != 0) {
dbgln_if(JPEG_DEBUG, "{}: ERROR! Start of Selection: {}, End of Selection: {}, Successive Approximation: {}!", dbgln_if(JPEG_DEBUG, "{}: ERROR! Start of Selection: {}, End of Selection: {}, Successive Approximation: {}!",
TRY(stream.tell()), TRY(stream.tell()),
spectral_selection_start, context.spectral_selection_start,
spectral_selection_end, context.spectral_selection_end,
successive_approximation); context.successive_approximation);
return Error::from_string_literal("Spectral selection is not [0,63] or successive approximation is not null"); return Error::from_string_literal("Spectral selection is not [0,63] or successive approximation is not null");
} }
return {}; return {};