From d42d655853d1f09a55699553bd8a2f2714bac960 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 11 Sep 2021 14:05:12 +0200 Subject: [PATCH] LibJS+LibWeb+Spreadsheet: Upcall visit_edges() via Base typedef Let's use Base::visit_edges() when calling the base class, to prevent accidentally skipping over anyone in the inheritance chain. --- Userland/Applications/Spreadsheet/JSIntegration.cpp | 2 +- Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp | 2 +- Userland/Libraries/LibJS/Runtime/BigIntObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/DataView.cpp | 2 +- Userland/Libraries/LibJS/Runtime/FinalizationRegistry.cpp | 2 +- Userland/Libraries/LibJS/Runtime/FunctionObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/GeneratorObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/Map.cpp | 2 +- Userland/Libraries/LibJS/Runtime/ProxyObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/RegExpStringIterator.cpp | 2 +- Userland/Libraries/LibJS/Runtime/Set.cpp | 2 +- Userland/Libraries/LibJS/Runtime/StringObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/SymbolObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/TypedArray.cpp | 2 +- Userland/Libraries/LibJS/Runtime/WeakRef.cpp | 2 +- .../Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp | 2 +- 16 files changed, 16 insertions(+), 16 deletions(-) diff --git a/Userland/Applications/Spreadsheet/JSIntegration.cpp b/Userland/Applications/Spreadsheet/JSIntegration.cpp index 0b8cb6fcb0..d2d0cf63be 100644 --- a/Userland/Applications/Spreadsheet/JSIntegration.cpp +++ b/Userland/Applications/Spreadsheet/JSIntegration.cpp @@ -150,7 +150,7 @@ void SheetGlobalObject::initialize_global_object() void SheetGlobalObject::visit_edges(Visitor& visitor) { - GlobalObject::visit_edges(visitor); + Base::visit_edges(visitor); for (auto& it : m_sheet.cells()) { if (it.value->exception()) visitor.visit(it.value->exception()); diff --git a/Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp b/Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp index c92bc590e4..b2d04c610f 100644 --- a/Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp +++ b/Userland/Libraries/LibJS/Runtime/ArrayBuffer.cpp @@ -44,7 +44,7 @@ ArrayBuffer::~ArrayBuffer() void ArrayBuffer::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_detach_key); } diff --git a/Userland/Libraries/LibJS/Runtime/BigIntObject.cpp b/Userland/Libraries/LibJS/Runtime/BigIntObject.cpp index 0600f591f9..a50d125532 100644 --- a/Userland/Libraries/LibJS/Runtime/BigIntObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/BigIntObject.cpp @@ -26,7 +26,7 @@ BigIntObject::~BigIntObject() void BigIntObject::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(&m_bigint); } diff --git a/Userland/Libraries/LibJS/Runtime/DataView.cpp b/Userland/Libraries/LibJS/Runtime/DataView.cpp index ce6856da4c..3dd74b4e69 100644 --- a/Userland/Libraries/LibJS/Runtime/DataView.cpp +++ b/Userland/Libraries/LibJS/Runtime/DataView.cpp @@ -27,7 +27,7 @@ DataView::~DataView() void DataView::visit_edges(Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_viewed_array_buffer); } diff --git a/Userland/Libraries/LibJS/Runtime/FinalizationRegistry.cpp b/Userland/Libraries/LibJS/Runtime/FinalizationRegistry.cpp index 01713fa39f..0a57afea56 100644 --- a/Userland/Libraries/LibJS/Runtime/FinalizationRegistry.cpp +++ b/Userland/Libraries/LibJS/Runtime/FinalizationRegistry.cpp @@ -75,7 +75,7 @@ void FinalizationRegistry::cleanup(FunctionObject* callback) void FinalizationRegistry::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_cleanup_callback); for (auto& record : m_records) { visitor.visit(record.held_value); diff --git a/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp b/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp index ba0bdd2bb5..341ac80169 100644 --- a/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/FunctionObject.cpp @@ -85,7 +85,7 @@ void FunctionObject::InstanceField::define_field(VM& vm, Object& receiver) const void FunctionObject::visit_edges(Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_home_object); visitor.visit(m_bound_this); diff --git a/Userland/Libraries/LibJS/Runtime/GeneratorObject.cpp b/Userland/Libraries/LibJS/Runtime/GeneratorObject.cpp index 2b4529737b..60a7df6082 100644 --- a/Userland/Libraries/LibJS/Runtime/GeneratorObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/GeneratorObject.cpp @@ -43,7 +43,7 @@ GeneratorObject::~GeneratorObject() void GeneratorObject::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_environment); visitor.visit(m_generating_function); if (m_previous_value.is_object()) diff --git a/Userland/Libraries/LibJS/Runtime/Map.cpp b/Userland/Libraries/LibJS/Runtime/Map.cpp index a3bc8ac05a..e5c0a59a5f 100644 --- a/Userland/Libraries/LibJS/Runtime/Map.cpp +++ b/Userland/Libraries/LibJS/Runtime/Map.cpp @@ -24,7 +24,7 @@ Map::~Map() void Map::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); for (auto& value : m_entries) { visitor.visit(value.key); visitor.visit(value.value); diff --git a/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp b/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp index f8db9de87d..3637b07f50 100644 --- a/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp @@ -1023,7 +1023,7 @@ Value ProxyObject::construct(FunctionObject& new_target) void ProxyObject::visit_edges(Cell::Visitor& visitor) { - FunctionObject::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(&m_target); visitor.visit(&m_handler); } diff --git a/Userland/Libraries/LibJS/Runtime/RegExpStringIterator.cpp b/Userland/Libraries/LibJS/Runtime/RegExpStringIterator.cpp index 93d6e24603..5c3634c12e 100644 --- a/Userland/Libraries/LibJS/Runtime/RegExpStringIterator.cpp +++ b/Userland/Libraries/LibJS/Runtime/RegExpStringIterator.cpp @@ -26,7 +26,7 @@ RegExpStringIterator::RegExpStringIterator(Object& prototype, Object& regexp_obj void RegExpStringIterator::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(&m_regexp_object); } diff --git a/Userland/Libraries/LibJS/Runtime/Set.cpp b/Userland/Libraries/LibJS/Runtime/Set.cpp index 8c8a47fa1b..dfaaf0b28a 100644 --- a/Userland/Libraries/LibJS/Runtime/Set.cpp +++ b/Userland/Libraries/LibJS/Runtime/Set.cpp @@ -24,7 +24,7 @@ Set::~Set() void Set::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); for (auto& value : m_values) visitor.visit(value); } diff --git a/Userland/Libraries/LibJS/Runtime/StringObject.cpp b/Userland/Libraries/LibJS/Runtime/StringObject.cpp index fd8d950604..06fe93fa08 100644 --- a/Userland/Libraries/LibJS/Runtime/StringObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/StringObject.cpp @@ -39,7 +39,7 @@ void StringObject::initialize(GlobalObject& global_object) void StringObject::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(&m_string); } diff --git a/Userland/Libraries/LibJS/Runtime/SymbolObject.cpp b/Userland/Libraries/LibJS/Runtime/SymbolObject.cpp index 9dbbb836a9..9431e1e2a6 100644 --- a/Userland/Libraries/LibJS/Runtime/SymbolObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/SymbolObject.cpp @@ -27,7 +27,7 @@ SymbolObject::~SymbolObject() void SymbolObject::visit_edges(Cell::Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(&m_symbol); } diff --git a/Userland/Libraries/LibJS/Runtime/TypedArray.cpp b/Userland/Libraries/LibJS/Runtime/TypedArray.cpp index 0cac033ff6..ac1781e6c5 100644 --- a/Userland/Libraries/LibJS/Runtime/TypedArray.cpp +++ b/Userland/Libraries/LibJS/Runtime/TypedArray.cpp @@ -263,7 +263,7 @@ TypedArrayBase* typed_array_create(GlobalObject& global_object, FunctionObject& void TypedArrayBase::visit_edges(Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_viewed_array_buffer); } diff --git a/Userland/Libraries/LibJS/Runtime/WeakRef.cpp b/Userland/Libraries/LibJS/Runtime/WeakRef.cpp index 85ac7b6621..b729722fd0 100644 --- a/Userland/Libraries/LibJS/Runtime/WeakRef.cpp +++ b/Userland/Libraries/LibJS/Runtime/WeakRef.cpp @@ -41,7 +41,7 @@ void WeakRef::remove_swept_cells(Badge, Span cells) void WeakRef::visit_edges(Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); if (vm().execution_generation() == m_last_execution_generation) visitor.visit(m_value); diff --git a/Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp b/Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp index a9931a6f23..c916c47299 100644 --- a/Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp +++ b/Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp @@ -59,7 +59,7 @@ void WebAssemblyInstanceObject::initialize(JS::GlobalObject& global_object) void WebAssemblyInstanceObject::visit_edges(Visitor& visitor) { - Object::visit_edges(visitor); + Base::visit_edges(visitor); visitor.visit(m_exports_object); }