From d43b306814aff2f3cf7064a3765b03a6b092847b Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 1 Feb 2023 11:14:03 -0500 Subject: [PATCH] LibGfx: Give ICC::TagType a virtual destructor ICC::Profile deletes these objects via base class pointers, so this is needed that destructors in the subclasses get called. (Found by asan on CI when adding test coverage.) --- Userland/Libraries/LibGfx/ICC/TagTypes.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Userland/Libraries/LibGfx/ICC/TagTypes.h b/Userland/Libraries/LibGfx/ICC/TagTypes.h index 7b08058081..dc3a6b2283 100644 --- a/Userland/Libraries/LibGfx/ICC/TagTypes.h +++ b/Userland/Libraries/LibGfx/ICC/TagTypes.h @@ -34,6 +34,8 @@ public: u32 size() const { return m_size; } TagTypeSignature type() const { return m_type; } + virtual ~TagData() = default; + protected: TagData(u32 offset, u32 size, TagTypeSignature type) : m_offset(offset)