RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 07:07:36 +00:00
Code Issues Activity Actions

LibWeb: Remember the selection state of each LayoutNode

Browse source 
Instead of computing it on the fly while painting each layout node,
they now remember their selection state. This avoids a whole bunch
of tree traversal while painting with anything selected.
This commit is contained in:
Andreas Kling 2020-08-21 17:50:41 +02:00
parent cf4870c93e
commit d47f77169f
6 changed files with 60 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibWeb/Layout/LayoutNode.h
View file

@ -43,6 +43,14 @@ namespace Web {
struct HitTestResult {
RefPtr<LayoutNode> layout_node;
int index_in_node { 0 };
enum InternalPosition {
None,
Before,
Inside,
After,
};
InternalPosition internal_position { None };
};
enum class HitTestType {
@ -142,6 +150,17 @@ public:
float font_size() const;
enum class SelectionState {
None, // No selection
Start, // Selection starts in this LayoutNode
End, // Selection ends in this LayoutNode
StartAndEnd, // Selection starts and ends in this LayoutNode
Full, // Selection starts before and ends after this LayoutNode
};
SelectionState selection_state() const { return m_selection_state; }
void set_selection_state(SelectionState state) { m_selection_state = state; }
protected:
LayoutNode(DOM::Document&, DOM::Node*);
@ -155,6 +174,7 @@ private:
bool m_has_style { false };
bool m_visible { true };
bool m_children_are_inline { false };
SelectionState m_selection_state { SelectionState::None };
};
class LayoutNodeWithStyle : public LayoutNode {