RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:37:45 +00:00
Code Issues Activity Actions

LibWeb: Resolve circular IDL imports

Browse source 
These circular imports led to the generator silently failing to
generate the required methods/properties.
This commit is contained in:
MacDue 2022-07-30 11:31:17 +01:00 • committed by Linus Groh
parent 8da0c36212
commit d4b2eb22e1
8 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/CharacterData.idl
View file

@ -16,3 +16,5 @@ interface CharacterData : Node {
readonly attribute Element? nextElementSibling;
readonly attribute Element? previousElementSibling;
};
CharacterData includes ChildNode;

6
Userland/Libraries/LibWeb/DOM/ChildNode.idl
View file

@ -1,5 +1,3 @@
#import <DOM/Node.idl>
// https://dom.spec.whatwg.org/#childnode
interface mixin ChildNode {
[CEReactions, Unscopable] undefined before((Node or DOMString)... nodes);
@ -7,7 +5,3 @@ interface mixin ChildNode {
[CEReactions, Unscopable] undefined replaceWith((Node or DOMString)... nodes);
[CEReactions, Unscopable, ImplementedAs=remove_binding] undefined remove();
};
DocumentType includes ChildNode;
Element includes ChildNode;
CharacterData includes ChildNode;

1
Userland/Libraries/LibWeb/DOM/Document.idl
View file

@ -100,4 +100,5 @@ interface Document : Node {
[NewObject] TreeWalker createTreeWalker(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null);
};
Document includes ParentNode;
Document includes GlobalEventHandlers;

2
Userland/Libraries/LibWeb/DOM/DocumentFragment.idl
View file

@ -10,3 +10,5 @@ interface DocumentFragment : Node {
Element? getElementById(DOMString id);
};
DocumentFragment includes ParentNode;

4
Userland/Libraries/LibWeb/DOM/Element.idl
View file

@ -53,3 +53,7 @@ interface Element : Node {
readonly attribute long clientWidth;
readonly attribute long clientHeight;
};
Element includes ParentNode;
Element includes ChildNode;
Element includes InnerHTML;

3
Userland/Libraries/LibWeb/DOM/InnerHTML.idl
View file

@ -2,6 +2,3 @@
interface mixin InnerHTML {
[LegacyNullToEmptyString, CEReactions] attribute DOMString innerHTML;
};
Element includes InnerHTML;
ShadowRoot includes InnerHTML;

5
Userland/Libraries/LibWeb/DOM/ParentNode.idl
View file

@ -1,4 +1,3 @@
#import <DOM/Element.idl>
#import <DOM/HTMLCollection.idl>
#import <DOM/Node.idl>
@ -16,7 +15,3 @@ interface mixin ParentNode {
Element? querySelector(DOMString selectors);
[NewObject] NodeList querySelectorAll(DOMString selectors);
};
Document includes ParentNode;
DocumentFragment includes ParentNode;
Element includes ParentNode;

2
Userland/Libraries/LibWeb/DOM/ShadowRoot.idl
View file

@ -11,5 +11,7 @@ interface ShadowRoot : DocumentFragment {
// FIXME: attribute EventHandler onslotchange;
};
ShadowRoot includes InnerHTML;
enum ShadowRootMode { "open", "closed" };
enum SlotAssignmentMode { "manual", "named" };