RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-23 14:22:08 +00:00
Code Issues Activity Actions

LibWeb: Extract the ParentNode IDL mixin

Browse source
This commit is contained in:
Sam Atkins 2022-07-27 19:51:49 +01:00 • committed by Linus Groh
parent 79fdc08de9
commit d4c40e3aad
4 changed files with 27 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/DOM/Document.idl
View file

@ -11,6 +11,7 @@
#import <DOM/NodeFilter.idl> #import <DOM/NodeFilter.idl>
#import <DOM/NodeIterator.idl> #import <DOM/NodeIterator.idl>
#import <DOM/NodeList.idl> #import <DOM/NodeList.idl>
#import <DOM/ParentNode.idl>
#import <DOM/Range.idl> #import <DOM/Range.idl>
#import <DOM/Text.idl> #import <DOM/Text.idl>
#import <DOM/TreeWalker.idl> #import <DOM/TreeWalker.idl>
@ -18,8 +19,8 @@
#import <HTML/HTMLHeadElement.idl> #import <HTML/HTMLHeadElement.idl>
#import <HTML/HTMLScriptElement.idl> #import <HTML/HTMLScriptElement.idl>
// https://dom.spec.whatwg.org/#document
interface Document : Node { interface Document : Node {
constructor(); constructor();
boolean hasFocus(); boolean hasFocus();
@ -92,26 +93,11 @@ interface Document : Node {
attribute DOMString title; attribute DOMString title;
// FIXME: These should all come from a ParentNode mixin
readonly attribute Element? firstElementChild;
readonly attribute Element? lastElementChild;
readonly attribute unsigned long childElementCount;
[CEReactions, Unscopable] undefined prepend((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined append((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined replaceChildren((Node or DOMString)... nodes);
Element? querySelector(DOMString selectors);
[NewObject] NodeList querySelectorAll(DOMString selectors);
[SameObject] readonly attribute HTMLCollection children;
readonly boolean hidden; readonly boolean hidden;
readonly DOMString visibilityState; readonly DOMString visibilityState;
[NewObject] NodeIterator createNodeIterator(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null); [NewObject] NodeIterator createNodeIterator(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null);
[NewObject] TreeWalker createTreeWalker(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null); [NewObject] TreeWalker createTreeWalker(Node root, optional unsigned long whatToShow = 0xFFFFFFFF, optional NodeFilter? filter = null);
}; };
Document includes GlobalEventHandlers; Document includes GlobalEventHandlers;

18
Userland/Libraries/LibWeb/DOM/DocumentFragment.idl
View file

@ -2,25 +2,11 @@
#import <DOM/HTMLCollection.idl> #import <DOM/HTMLCollection.idl>
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/NodeList.idl> #import <DOM/NodeList.idl>
#import <DOM/ParentNode.idl>
// https://dom.spec.whatwg.org/#documentfragment
interface DocumentFragment : Node { interface DocumentFragment : Node {
constructor(); constructor();
Element? getElementById(DOMString id); Element? getElementById(DOMString id);
// FIXME: These should all come from a ParentNode mixin
readonly attribute Element? firstElementChild;
readonly attribute Element? lastElementChild;
readonly attribute unsigned long childElementCount;
[CEReactions, Unscopable] undefined prepend((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined append((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined replaceChildren((Node or DOMString)... nodes);
Element? querySelector(DOMString selectors);
[NewObject] NodeList querySelectorAll(DOMString selectors);
[SameObject] readonly attribute HTMLCollection children;
}; };

15
Userland/Libraries/LibWeb/DOM/Element.idl
View file

@ -4,6 +4,7 @@
#import <DOM/NamedNodeMap.idl> #import <DOM/NamedNodeMap.idl>
#import <DOM/Node.idl> #import <DOM/Node.idl>
#import <DOM/NodeList.idl> #import <DOM/NodeList.idl>
#import <DOM/ParentNode.idl>
#import <Geometry/DOMRect.idl> #import <Geometry/DOMRect.idl>
#import <Geometry/DOMRectList.idl> #import <Geometry/DOMRectList.idl>
@ -46,20 +47,6 @@ interface Element : Node {
[ImplementedAs=style_for_bindings] readonly attribute CSSStyleDeclaration style; [ImplementedAs=style_for_bindings] readonly attribute CSSStyleDeclaration style;
// FIXME: These should all come from a ParentNode mixin (up to and including children)
readonly attribute Element? firstElementChild;
readonly attribute Element? lastElementChild;
readonly attribute unsigned long childElementCount;
[CEReactions, Unscopable] undefined prepend((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined append((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined replaceChildren((Node or DOMString)... nodes);
Element? querySelector(DOMString selectors);
[NewObject] NodeList querySelectorAll(DOMString selectors);
[SameObject] readonly attribute HTMLCollection children;
DOMRect getBoundingClientRect(); DOMRect getBoundingClientRect();
DOMRectList getClientRects(); DOMRectList getClientRects();

22
Userland/Libraries/LibWeb/DOM/ParentNode.idl Normal file
View file

@ -0,0 +1,22 @@
#import <DOM/Element.idl>
#import <DOM/HTMLCollection.idl>
#import <DOM/Node.idl>
// https://dom.spec.whatwg.org/#parentnode
interface mixin ParentNode {
[SameObject] readonly attribute HTMLCollection children;
readonly attribute Element? firstElementChild;
readonly attribute Element? lastElementChild;
readonly attribute unsigned long childElementCount;
[CEReactions, Unscopable] undefined prepend((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined append((Node or DOMString)... nodes);
[CEReactions, Unscopable] undefined replaceChildren((Node or DOMString)... nodes);
Element? querySelector(DOMString selectors);
[NewObject] NodeList querySelectorAll(DOMString selectors);
};
Document includes ParentNode;
DocumentFragment includes ParentNode;
Element includes ParentNode;