RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibJS: Basic implementation of most of Date's constructor arguments

Browse source 
The constructor with a string argument isn't implemented yet, but
this implements the other variants.

The timestamp constructor doens't handle negative timestamps correctly.

Out-of-bound and invalid arguments aren't handled correctly.
This commit is contained in:
Nico Weber 2020-08-20 10:41:10 -04:00 • committed by Andreas Kling
parent 45827cace9
commit d4d9222eea
2 changed files with 83 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

47
Libraries/LibJS/Runtime/DateConstructor.cpp
View file

@ -60,13 +60,48 @@ Value DateConstructor::call(Interpreter& interpreter)
return js_string(interpreter, static_cast<Date&>(date.as_object()).string());
}
Value DateConstructor::construct(Interpreter&, Function&)
Value DateConstructor::construct(Interpreter& interpreter, Function&)
{
// TODO: Support args
struct timeval tv;
gettimeofday(&tv, nullptr);
auto datetime = Core::DateTime::now();
auto milliseconds = static_cast<u16>(tv.tv_usec / 1000);
if (interpreter.argument_count() == 0) {
struct timeval tv;
gettimeofday(&tv, nullptr);
auto datetime = Core::DateTime::now();
auto milliseconds = static_cast<u16>(tv.tv_usec / 1000);
return Date::create(global_object(), datetime, milliseconds);
}
if (interpreter.argument_count() == 1 && interpreter.argument(0).is_string()) {
// FIXME: Parse simplified ISO8601-like string, like Date.parse() will do.
struct timeval tv;
gettimeofday(&tv, nullptr);
auto datetime = Core::DateTime::now();
auto milliseconds = static_cast<u16>(tv.tv_usec / 1000);
return Date::create(global_object(), datetime, milliseconds);
}
if (interpreter.argument_count() == 1) {
// A timestamp since the epoch, in UTC.
// FIXME: Date() probably should use a double as internal representation, so that NaN arguments and larger offsets are handled correctly.
// FIXME: DateTime::from_timestamp() seems to not support negative offsets.
double value = interpreter.argument(0).to_double(interpreter);
auto datetime = Core::DateTime::from_timestamp(static_cast<time_t>(value / 1000));
auto milliseconds = static_cast<u16>(fmod(value, 1000));
return Date::create(global_object(), datetime, milliseconds);
}
// A date/time in components, in local time.
// FIXME: This doesn't construct an "Invalid Date" object if one of the parameters is NaN.
// FIXME: This doesn't range-check args and convert months > 12 to year increments etc.
auto arg_or = [&interpreter](size_t i, i32 fallback) { return interpreter.argument_count() > i ? interpreter.argument(i).to_i32(interpreter) : fallback; };
int year = interpreter.argument(0).to_i32(interpreter);
int month_index = interpreter.argument(1).to_i32(interpreter);
int day = arg_or(2, 1);
int hours = arg_or(3, 0);
int minutes = arg_or(4, 0);
int seconds = arg_or(5, 0);
int milliseconds = arg_or(6, 0);
if (year >= 0 && year <= 99)
year += 1900;
int month = month_index + 1;
auto datetime = Core::DateTime::create(year, month, day, hours, minutes, seconds);
return Date::create(global_object(), datetime, milliseconds);
}