RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 12:52:44 +00:00
Code Issues Activity Actions

LibGUI: Abstract out and name repeated logic

Browse source
This commit is contained in:
thislooksfun 2021-10-27 19:45:34 -05:00 • committed by Andreas Kling
parent d73d044f2b
commit d4eef0f17d
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibGUI/GMLAutocompleteProvider.cpp
View file

@ -155,9 +155,10 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
identifier_entries.empend("layout: ", partial_input_length, Language::Unspecified, "layout");
};
bool after_token_on_same_line = last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line();
switch (state) {
case Free:
if (last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line()) {
if (after_token_on_same_line) {
// After some token, but with extra space, not on a new line.
// Nothing to put here.
break;
@ -168,7 +169,7 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
case InClassName: {
if (class_names.is_empty())
break;
if (last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line()) {
if (after_token_on_same_line) {
// After a class name, but haven't seen braces.
// TODO: Suggest braces?
break;
@ -184,7 +185,7 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
break;
}
case InIdentifier: {
if (last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line()) {
if (after_token_on_same_line) {
// After an identifier, but with extra space
// TODO: Maybe suggest a colon?
break;