RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:47:36 +00:00
Code Issues Activity Actions

Everywhere: Use 'increase_slider_by()' method from AbstractSlider

Browse source 
This method help us to avoid repeating the pattern
'set_value(value() + delta)'.
This commit is contained in:
Elyse 2021-12-28 21:47:26 -06:00 • committed by Andreas Kling
parent 8b8f404146
commit d53e1fa1fa
12 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PixelPaint/LayerListWidget.cpp
View file

@ -248,7 +248,7 @@ void LayerListWidget::on_automatic_scrolling_timer_fired()
if (vertical_scrollbar().is_max() && m_automatic_scroll_delta.y() > 0)
return;
vertical_scrollbar().set_value(vertical_scrollbar().value() + m_automatic_scroll_delta.y());
vertical_scrollbar().increase_slider_by(m_automatic_scroll_delta.y());
gadget.movement_delta.set_y(gadget.movement_delta.y() + m_automatic_scroll_delta.y());
auto inner_rect_max_height = widget_inner_rect().height() - 2 + vertical_scrollbar().max();

4
Userland/Applications/PixelPaint/Tools/Tool.cpp
View file

@ -38,7 +38,7 @@ void Tool::on_keydown(GUI::KeyEvent& event)
break;
case KeyCode::Key_RightBracket:
if (m_primary_slider)
m_primary_slider->set_value(m_primary_slider->value() + 1);
m_primary_slider->increase_slider_by(1);
break;
case KeyCode::Key_LeftBrace:
if (m_secondary_slider)
@ -46,7 +46,7 @@ void Tool::on_keydown(GUI::KeyEvent& event)
break;
case KeyCode::Key_RightBrace:
if (m_secondary_slider)
m_secondary_slider->set_value(m_secondary_slider->value() + 1);
m_secondary_slider->increase_slider_by(1);
break;
default:
break;