RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:07:45 +00:00
Code Issues Activity Actions

Everywhere: Use 'increase_slider_by()' method from AbstractSlider

Browse source 
This method help us to avoid repeating the pattern
'set_value(value() + delta)'.
This commit is contained in:
Elyse 2021-12-28 21:47:26 -06:00 • committed by Andreas Kling
parent 8b8f404146
commit d53e1fa1fa
12 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/AbstractScrollableWidget.cpp
View file

@ -49,9 +49,9 @@ void AbstractScrollableWidget::handle_wheel_event(MouseEvent& event, Widget& eve
}
// FIXME: The wheel delta multiplier should probably come from... somewhere?
if (event.shift() || &event_source == m_horizontal_scrollbar.ptr()) {
horizontal_scrollbar().set_value(horizontal_scrollbar().value() + event.wheel_delta() * 60);
horizontal_scrollbar().increase_slider_by(event.wheel_delta() * 60);
} else {
vertical_scrollbar().set_value(vertical_scrollbar().value() + event.wheel_delta() * 20);
vertical_scrollbar().increase_slider_by(event.wheel_delta() * 20);
}
}

4
Userland/Libraries/LibGUI/AbstractView.cpp
View file

@ -797,8 +797,8 @@ void AbstractView::on_automatic_scrolling_timer_fired()
if (m_automatic_scroll_delta.is_null())
return;
vertical_scrollbar().set_value(vertical_scrollbar().value() + m_automatic_scroll_delta.y());
horizontal_scrollbar().set_value(horizontal_scrollbar().value() + m_automatic_scroll_delta.x());
vertical_scrollbar().increase_slider_by(m_automatic_scroll_delta.y());
horizontal_scrollbar().increase_slider_by(m_automatic_scroll_delta.x());
}
}

2
Userland/Libraries/LibGUI/Scrollbar.cpp
View file

@ -332,7 +332,7 @@ void Scrollbar::scroll_by_page(const Gfx::IntPoint& click_position)
set_value(value() - page_increment);
} else {
gutter_click_state = GutterClickState::AfterScrubber;
set_value(value() + page_increment);
increase_slider_by(page_increment);
}
}

2
Userland/Libraries/LibGUI/Slider.cpp
View file

@ -149,7 +149,7 @@ void Slider::mousewheel_event(MouseEvent& event)
if (orientation() == Orientation::Horizontal)
set_value(value() - wheel_delta * acceleration_modifier);
else
set_value(value() + wheel_delta * acceleration_modifier);
increase_slider_by(wheel_delta * acceleration_modifier);
Widget::mousewheel_event(event);
}

4
Userland/Libraries/LibGUI/ValueSlider.cpp
View file

@ -46,7 +46,7 @@ ValueSlider::ValueSlider(Gfx::Orientation orientation, String suffix)
m_textbox->on_up_pressed = [&]() {
if (value() < max())
AbstractSlider::set_value(value() + 1);
AbstractSlider::increase_slider_by(1);
m_textbox->set_text(formatted_value());
};
@ -159,7 +159,7 @@ void ValueSlider::leave_event(Core::Event&)
void ValueSlider::mousewheel_event(MouseEvent& event)
{
if (event.wheel_delta() < 0)
set_value(value() + 1);
increase_slider_by(1);
else
set_value(value() - 1);
}