RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:07:45 +00:00
Code Issues Activity Actions

LibJS: Convert init_typed_array_from_array_like() to ThrowCompletionOr

Browse source 
Also add spec step comments to it while we're here.
This commit is contained in:
Linus Groh 2021-10-03 20:50:38 +01:00
parent 8e3957767e
commit d551e0e55e
1 changed files with 47 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

73
Userland/Libraries/LibJS/Runtime/TypedArray.cpp
View file

@ -239,44 +239,65 @@ static ThrowCompletionOr<void> initialize_typed_array_from_typed_array(GlobalObj
// 23.2.5.1.5 InitializeTypedArrayFromArrayLike, https://tc39.es/ecma262/#sec-initializetypedarrayfromarraylike // 23.2.5.1.5 InitializeTypedArrayFromArrayLike, https://tc39.es/ecma262/#sec-initializetypedarrayfromarraylike
template<typename T> template<typename T>
static void initialize_typed_array_from_array_like(GlobalObject& global_object, TypedArray<T>& typed_array, const Object& array_like) static ThrowCompletionOr<void> initialize_typed_array_from_array_like(GlobalObject& global_object, TypedArray<T>& typed_array, const Object& array_like)
{ {
auto& vm = global_object.vm(); auto& vm = global_object.vm();
auto length_or_error = length_of_array_like(global_object, array_like);
if (length_or_error.is_error()) // 1. Let len be ? LengthOfArrayLike(arrayLike).
return; auto length = TRY(length_of_array_like(global_object, array_like));
auto length = length_or_error.release_value();
// 2. Perform ? AllocateTypedArrayBuffer(O, len).
// 23.2.5.1.6 AllocateTypedArrayBuffer ( O, length )
// Enforce 2GB "Excessive Length" limit // Enforce 2GB "Excessive Length" limit
if (length > NumericLimits<i32>::max() / sizeof(T)) { if (length > NumericLimits<i32>::max() / sizeof(T))
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "typed array"); return vm.template throw_completion<RangeError>(global_object, ErrorType::InvalidLength, "typed array");
return;
}
// 1. Assert: O.[[ViewedArrayBuffer]] is undefined.
// 2. Let constructorName be the String value of O.[[TypedArrayName]].
// 3. Let elementSize be the Element Size value specified in Table 72 for constructorName.
auto element_size = typed_array.element_size(); auto element_size = typed_array.element_size();
if (Checked<size_t>::multiplication_would_overflow(element_size, length)) { if (Checked<size_t>::multiplication_would_overflow(element_size, length))
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "typed array"); return vm.template throw_completion<RangeError>(global_object, ErrorType::InvalidLength, "typed array");
return;
}
auto byte_length = element_size * length;
auto array_buffer = ArrayBuffer::create(global_object, byte_length);
if (!array_buffer)
return;
typed_array.set_viewed_array_buffer(array_buffer); // 4. Let byteLength be elementSize × length.
auto byte_length = element_size * length;
// 5. Let data be ? AllocateArrayBuffer(%ArrayBuffer%, byteLength).
auto* data = ArrayBuffer::create(global_object, byte_length);
if (auto* exception = vm.exception())
return throw_completion(exception->value());
// 6. Set O.[[ViewedArrayBuffer]] to data.
typed_array.set_viewed_array_buffer(data);
// 7. Set O.[[ByteLength]] to byteLength.
typed_array.set_byte_length(byte_length); typed_array.set_byte_length(byte_length);
// 8. Set O.[[ByteOffset]] to 0.
typed_array.set_byte_offset(0); typed_array.set_byte_offset(0);
// 9. Set O.[[ArrayLength]] to length.
typed_array.set_array_length(length); typed_array.set_array_length(length);
// 10. Return O.
// End of 23.2.5.1.6
// 4. Repeat, while k < len,
for (size_t k = 0; k < length; k++) { for (size_t k = 0; k < length; k++) {
auto value_or_error = array_like.get(k); // a. Let Pk be ! ToString(𝔽(k)).
if (value_or_error.is_error()) // b. Let kValue be ? Get(arrayLike, Pk).
return; auto k_value = TRY(array_like.get(k));
auto value = value_or_error.release_value();
auto result_or_error = typed_array.set(k, value, Object::ShouldThrowExceptions::Yes); // c. Perform ? Set(O, Pk, kValue, true).
if (result_or_error.is_error()) TRY(typed_array.set(k, k_value, Object::ShouldThrowExceptions::Yes));
return;
// d. Set k to k + 1.
} }
return {};
} }
// 23.2.5.1.4 InitializeTypedArrayFromList, https://tc39.es/ecma262/#sec-initializetypedarrayfromlist // 23.2.5.1.4 InitializeTypedArrayFromList, https://tc39.es/ecma262/#sec-initializetypedarrayfromlist
@ -447,7 +468,7 @@ void TypedArrayBase::visit_edges(Visitor& visitor)
return {}; \ return {}; \
initialize_typed_array_from_list(global_object(), *typed_array, values); \ initialize_typed_array_from_list(global_object(), *typed_array, values); \
} else { \ } else { \
initialize_typed_array_from_array_like(global_object(), *typed_array, first_argument.as_object()); \ TRY_OR_DISCARD(initialize_typed_array_from_array_like(global_object(), *typed_array, first_argument.as_object())); \
} \ } \
if (vm.exception()) \ if (vm.exception()) \
return {}; \ return {}; \