RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

Kernel/Graphics: Don't declare VGA changing-state methods as const

Browse source
This commit is contained in:
Liav A 2022-03-18 11:58:34 +02:00 • committed by Brian Gianforcaro
parent 174a25db5b
commit d56544aca0
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Graphics/GraphicsManagement.cpp
View file

@ -62,7 +62,7 @@ void GraphicsManagement::disable_vga_emulation_access_permanently()
m_vga_access_is_disabled = true; m_vga_access_is_disabled = true;
} }
void GraphicsManagement::enable_vga_text_mode_console_cursor() const void GraphicsManagement::enable_vga_text_mode_console_cursor()
{ {
SpinlockLocker locker(m_main_vga_lock); SpinlockLocker locker(m_main_vga_lock);
if (m_vga_access_is_disabled) if (m_vga_access_is_disabled)
@ -71,7 +71,7 @@ void GraphicsManagement::enable_vga_text_mode_console_cursor() const
IO::out8(0x3D5, 0); IO::out8(0x3D5, 0);
} }
void GraphicsManagement::disable_vga_text_mode_console_cursor() const void GraphicsManagement::disable_vga_text_mode_console_cursor()
{ {
SpinlockLocker locker(m_main_vga_lock); SpinlockLocker locker(m_main_vga_lock);
if (m_vga_access_is_disabled) if (m_vga_access_is_disabled)
@ -80,7 +80,7 @@ void GraphicsManagement::disable_vga_text_mode_console_cursor() const
IO::out8(0x3D5, 0x20); IO::out8(0x3D5, 0x20);
} }
void GraphicsManagement::set_vga_text_mode_cursor(size_t console_width, size_t x, size_t y) const void GraphicsManagement::set_vga_text_mode_cursor(size_t console_width, size_t x, size_t y)
{ {
SpinlockLocker locker(m_main_vga_lock); SpinlockLocker locker(m_main_vga_lock);
if (m_vga_access_is_disabled) if (m_vga_access_is_disabled)

8
Kernel/Graphics/GraphicsManagement.h
View file

@ -33,8 +33,8 @@ public:
bool framebuffer_devices_use_bootloader_framebuffer() const; bool framebuffer_devices_use_bootloader_framebuffer() const;
bool framebuffer_devices_exist() const; bool framebuffer_devices_exist() const;
void set_vga_text_mode_cursor(size_t console_width, size_t x, size_t y) const; void set_vga_text_mode_cursor(size_t console_width, size_t x, size_t y);
void disable_vga_text_mode_console_cursor() const; void disable_vga_text_mode_console_cursor();
void disable_vga_emulation_access_permanently(); void disable_vga_emulation_access_permanently();
RefPtr<Graphics::Console> console() const { return m_console; } RefPtr<Graphics::Console> console() const { return m_console; }
@ -44,7 +44,7 @@ public:
void activate_graphical_mode(); void activate_graphical_mode();
private: private:
void enable_vga_text_mode_console_cursor() const; void enable_vga_text_mode_console_cursor();
bool determine_and_initialize_graphics_device(PCI::DeviceIdentifier const&); bool determine_and_initialize_graphics_device(PCI::DeviceIdentifier const&);
bool determine_and_initialize_isa_graphics_device(); bool determine_and_initialize_isa_graphics_device();
@ -55,7 +55,7 @@ private:
RefPtr<VGACompatibleAdapter> m_vga_adapter; RefPtr<VGACompatibleAdapter> m_vga_adapter;
unsigned m_current_minor_number { 0 }; unsigned m_current_minor_number { 0 };
mutable RecursiveSpinlock m_main_vga_lock; RecursiveSpinlock m_main_vga_lock;
bool m_vga_access_is_disabled { false }; bool m_vga_access_is_disabled { false };
}; };