RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:17:45 +00:00
Code Issues Activity Actions

LibWeb/DOM: Rename Node::{paint => paintable}_box()

Browse source 
It returns a PaintableBox, not a 'PaintBox'.
This commit is contained in:
Linus Groh 2023-04-20 16:01:16 +01:00 • committed by Andreas Kling
parent 754e458d0a
commit d58b671ff6
8 changed files with 25 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -2041,8 +2041,8 @@ void Document::decrement_number_of_things_delaying_the_load_event(Badge<Document
void Document::invalidate_stacking_context_tree()
{
if (auto* paint_box = this->paint_box())
const_cast<Painting::PaintableBox*>(paint_box)->invalidate_stacking_context();
if (auto* paintable_box = this->paintable_box())
const_cast<Painting::PaintableBox*>(paintable_box)->invalidate_stacking_context();
}
void Document::check_favicon_after_loading_link_resource()

14
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -699,14 +699,14 @@ JS::NonnullGCPtr<Geometry::DOMRect> Element::get_bounding_client_rect() const
const_cast<Document&>(document()).update_layout();
// FIXME: Support inline layout nodes as well.
auto* paint_box = this->paint_box();
if (!paint_box)
auto* paintable_box = this->paintable_box();
if (!paintable_box)
return Geometry::DOMRect::construct_impl(realm(), 0, 0, 0, 0).release_value_but_fixme_should_propagate_errors();
VERIFY(document().browsing_context());
auto viewport_offset = document().browsing_context()->viewport_scroll_offset();
return Geometry::DOMRect::create(realm(), paint_box->absolute_rect().translated(-viewport_offset.x(), -viewport_offset.y()).to_type<float>()).release_value_but_fixme_should_propagate_errors();
return Geometry::DOMRect::create(realm(), paintable_box->absolute_rect().translated(-viewport_offset.x(), -viewport_offset.y()).to_type<float>()).release_value_but_fixme_should_propagate_errors();
}
// https://drafts.csswg.org/cssom-view/#dom-element-getclientrects
@ -784,12 +784,12 @@ int Element::client_width() const
const_cast<Document&>(document()).update_layout();
// 1. If the element has no associated CSS layout box or if the CSS layout box is inline, return zero.
if (!paint_box())
if (!paintable_box())
return 0;
// 3. Return the width of the padding edge excluding the width of any rendered scrollbar between the padding edge and the border edge,
// ignoring any transforms that apply to the element and its ancestors.
return paint_box()->absolute_padding_box_rect().width().value();
return paintable_box()->absolute_padding_box_rect().width().value();
}
// https://drafts.csswg.org/cssom-view/#dom-element-clientheight
@ -809,12 +809,12 @@ int Element::client_height() const
const_cast<Document&>(document()).update_layout();
// 1. If the element has no associated CSS layout box or if the CSS layout box is inline, return zero.
if (!paint_box())
if (!paintable_box())
return 0;
// 3. Return the height of the padding edge excluding the height of any rendered scrollbar between the padding edge and the border edge,
// ignoring any transforms that apply to the element and its ancestors.
return paint_box()->absolute_padding_box_rect().height().value();
return paintable_box()->absolute_padding_box_rect().height().value();
}
void Element::children_changed()

2
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -1407,7 +1407,7 @@ Painting::Paintable const* Node::paintable() const
return layout_node()->paintable();
}
Painting::PaintableBox const* Node::paint_box() const
Painting::PaintableBox const* Node::paintable_box() const
{
if (!layout_node())
return nullptr;

2
Userland/Libraries/LibWeb/DOM/Node.h
View file

@ -175,7 +175,7 @@ public:
Layout::Node const* layout_node() const { return m_layout_node; }
Layout::Node* layout_node() { return m_layout_node; }
Painting::PaintableBox const* paint_box() const;
Painting::PaintableBox const* paintable_box() const;
Painting::Paintable const* paintable() const;
void set_layout_node(Badge<Layout::Node>, JS::NonnullGCPtr<Layout::Node>);