RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 10:38:13 +00:00
Code Issues Activity Actions

LibTextCodec+Everywhere: Make TextCodec::decoder_for() take a StringView

Browse source 
We don't need a full String/DeprecatedString inside this function, so we
might as well not force users to create one.
This commit is contained in:
Sam Atkins 2023-02-13 17:23:31 +00:00 • committed by Tim Flynn
parent 3c8bfa4662
commit d6075ef5b5
14 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -1419,7 +1419,7 @@ JS_DEFINE_NATIVE_FUNCTION(Window::atob)
// The bytes object might contain bytes greater than 128, encode them in UTF8
// NOTE: Any 8-bit encoding -> utf-8 decoder will work for this
auto text_decoder = TextCodec::decoder_for("windows-1252");
auto text_decoder = TextCodec::decoder_for("windows-1252"sv);
VERIFY(text_decoder);
auto text = text_decoder->to_utf8(decoded.release_value());

2
Userland/Libraries/LibWeb/HTML/WorkerGlobalScope.cpp
View file

@ -158,7 +158,7 @@ WebIDL::ExceptionOr<DeprecatedString> WorkerGlobalScope::atob(DeprecatedString c
// 3. Return decodedData.
// decode_base64() returns a byte string. LibJS uses UTF-8 for strings. Use Latin1Decoder to convert bytes 128-255 to UTF-8.
auto* decoder = TextCodec::decoder_for("windows-1252");
auto* decoder = TextCodec::decoder_for("windows-1252"sv);
VERIFY(decoder);
return decoder->to_utf8(decoded_data.value());
}