From d66a42175799794dbe8ecf5461ee622b7ec4946f Mon Sep 17 00:00:00 2001 From: Lucas CHOLLET Date: Wed, 27 Dec 2023 21:03:42 -0500 Subject: [PATCH] LibGfx/TIFF: Enforce a length of one for more tags The TIFF spec is constructed in a way that many tags are defined in multiple places but some of these definitions are partial. If we look into "Section 8: Baseline Field Reference Guide", we can see that these tags indeed have an enforced length of 1. --- Userland/Libraries/LibGfx/TIFFGenerator.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibGfx/TIFFGenerator.py b/Userland/Libraries/LibGfx/TIFFGenerator.py index d821119ebf..f0bd795d31 100755 --- a/Userland/Libraries/LibGfx/TIFFGenerator.py +++ b/Userland/Libraries/LibGfx/TIFFGenerator.py @@ -118,11 +118,11 @@ known_tags: List[Tag] = [ Tag('277', [TIFFType.UnsignedShort], [1], None, "SamplesPerPixel", is_required=True), Tag('278', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [1], None, "RowsPerStrip", is_required=True), Tag('279', [TIFFType.UnsignedShort, TIFFType.UnsignedLong], [], None, "StripByteCounts", is_required=True), - Tag('282', [TIFFType.UnsignedRational], [], None, "XResolution"), - Tag('283', [TIFFType.UnsignedRational], [], None, "YResolution"), - Tag('284', [TIFFType.UnsignedShort], [], PlanarConfiguration.Chunky, "PlanarConfiguration", PlanarConfiguration), + Tag('282', [TIFFType.UnsignedRational], [1], None, "XResolution"), + Tag('283', [TIFFType.UnsignedRational], [1], None, "YResolution"), + Tag('284', [TIFFType.UnsignedShort], [1], PlanarConfiguration.Chunky, "PlanarConfiguration", PlanarConfiguration), Tag('285', [TIFFType.ASCII], [], None, "PageName"), - Tag('296', [TIFFType.UnsignedShort], [], ResolutionUnit.Inch, "ResolutionUnit", ResolutionUnit), + Tag('296', [TIFFType.UnsignedShort], [1], ResolutionUnit.Inch, "ResolutionUnit", ResolutionUnit), Tag('339', [TIFFType.UnsignedShort], [], SampleFormat.Unsigned, "SampleFormat", SampleFormat), Tag('317', [TIFFType.UnsignedShort], [1], Predictor.NoPrediction, "Predictor", Predictor), Tag('320', [TIFFType.UnsignedShort], [], None, "ColorMap"),