RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

IRCClient: Escape HTML entities in nicknames, too, just in case

Browse source
This commit is contained in:
Andreas Kling 2019-11-07 18:09:52 +01:00
parent 68e23bca3f
commit d6f9349f15
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Applications/IRCClient/IRCLogBuffer.cpp
View file

@ -44,7 +44,7 @@ static String timestamp_string()
void IRCLogBuffer::add_message(char prefix, const String& name, const String& text, Color color) void IRCLogBuffer::add_message(char prefix, const String& name, const String& text, Color color)
{ {
auto nick_string = String::format("&lt;%c%s&gt; ", prefix ? prefix : ' ', name.characters()); auto nick_string = String::format("<%c%s> ", prefix ? prefix : ' ', name.characters());
auto html = String::format( auto html = String::format(
"<div style=\"color: %s\">" "<div style=\"color: %s\">"
"<span>%s</span>" "<span>%s</span>"
@ -53,7 +53,7 @@ void IRCLogBuffer::add_message(char prefix, const String& name, const String& te
"</div>", "</div>",
color.to_string().characters(), color.to_string().characters(),
timestamp_string().characters(), timestamp_string().characters(),
nick_string.characters(), escape_html_entities(nick_string).characters(),
escape_html_entities(text).characters()); escape_html_entities(text).characters());
auto fragment = parse_html_fragment(*m_document, html); auto fragment = parse_html_fragment(*m_document, html);
m_container_element->append_child(fragment->remove_child(*fragment->first_child())); m_container_element->append_child(fragment->remove_child(*fragment->first_child()));