RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:57:44 +00:00
Code Issues Activity Actions

LibWeb: Don't discard update_style_recursively() return value

Browse source 
This was causing us to miss layout invalidations. With this fixed, we
can remove the invalidation from Element::recompute_style() along with
the associated FIXME.

Thanks to Idan for spotting this! :^)
This commit is contained in:
Andreas Kling 2022-03-16 21:25:24 +01:00
parent bec0c96aea
commit d71b0e4638
2 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -317,9 +317,6 @@ Element::NeedsRelayout Element::recompute_style()
return NeedsRelayout::No;
}
// FIXME: Get rid of this layout invalidation and let Document take care of it.
// There seems to be some missing invalidation somewhere else that this is papering over.
document().invalidate_layout();
return NeedsRelayout::Yes;
}