RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:07:35 +00:00
Code Issues Activity Actions

LibWeb: Don't discard update_style_recursively() return value

Browse source 
This was causing us to miss layout invalidations. With this fixed, we
can remove the invalidation from Element::recompute_style() along with
the associated FIXME.

Thanks to Idan for spotting this! :^)
This commit is contained in:
Andreas Kling 2022-03-16 21:25:24 +01:00
parent bec0c96aea
commit d71b0e4638
2 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -595,7 +595,7 @@ void Document::update_layout()
m_layout_update_timer->stop(); m_layout_update_timer->stop();
} }
static bool update_style_recursively(DOM::Node& node) [[nodiscard]] static bool update_style_recursively(DOM::Node& node)
{ {
bool needs_relayout = false; bool needs_relayout = false;
@ -613,7 +613,7 @@ static bool update_style_recursively(DOM::Node& node)
} }
node.for_each_child([&](auto& child) { node.for_each_child([&](auto& child) {
if (child.needs_style_update() || child.child_needs_style_update()) if (child.needs_style_update() || child.child_needs_style_update())
update_style_recursively(child); needs_relayout |= update_style_recursively(child);
return IterationDecision::Continue; return IterationDecision::Continue;
}); });
} }

3
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -317,9 +317,6 @@ Element::NeedsRelayout Element::recompute_style()
return NeedsRelayout::No; return NeedsRelayout::No;
} }
// FIXME: Get rid of this layout invalidation and let Document take care of it.
// There seems to be some missing invalidation somewhere else that this is papering over.
document().invalidate_layout();
return NeedsRelayout::Yes; return NeedsRelayout::Yes;
} }