From d720fb88456f818bfab3cd6504b27d26dc0e1f76 Mon Sep 17 00:00:00 2001 From: ronak69 Date: Wed, 17 Jan 2024 20:50:58 +0000 Subject: [PATCH] CMake: Set `CMAKE_COLOR_DIAGNOSTICS` to `ON` for colored diagnostics This patch removes the explicit compile flag that only works for g++ (`-fdiagnostics-color=always`; clang++ needs `-fcolor-diagnostics`) and uses CMake's built in variable that can control color output. Now both compilers should output colored diagnostics. --- Meta/CMake/common_compile_options.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Meta/CMake/common_compile_options.cmake b/Meta/CMake/common_compile_options.cmake index 57864e66c5..bdc8ea841f 100644 --- a/Meta/CMake/common_compile_options.cmake +++ b/Meta/CMake/common_compile_options.cmake @@ -3,6 +3,8 @@ set(CMAKE_CXX_STANDARD 20) set(CMAKE_CXX_STANDARD_REQUIRED ON) set(CMAKE_CXX_EXTENSIONS OFF) +set(CMAKE_COLOR_DIAGNOSTICS ON) + add_compile_options(-Wall) add_compile_options(-Wextra) @@ -11,7 +13,6 @@ add_compile_options(-Wno-invalid-offsetof) add_compile_options(-Wno-unknown-warning-option) add_compile_options(-Wno-unused-command-line-argument) -add_compile_options(-fdiagnostics-color=always) add_compile_options(-fno-exceptions) add_compile_options(-ffp-contract=off)