RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:38:10 +00:00
Code Issues Activity Actions

LibJS/Tests: Set failing bytecode tests as xfail when in bytecode mode

Browse source 
This should allow us to enable running test-js in bytecode mode in CI.
This commit is contained in:
Shannon Booth 2023-07-22 17:30:15 +12:00 • committed by Andreas Kling
parent 9b66e87bd8
commit d766014787
17 changed files with 145 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

47
Userland/Libraries/LibJS/Tests/loops/for-of-basic.js
View file

@ -130,26 +130,37 @@ describe("special left hand sides", () => {
expect(f().a).toBe("c");
});
test("call function is allowed in parsing but fails in runtime", () => {
function f() {
expect().fail();
test.xfailIf(
isBytecodeInterpreterEnabled(),
"call function is allowed in parsing but fails in runtime",
() => {
function f() {
expect().fail();
}
// Does not fail since it does not iterate but prettier does not like it so we use eval.
expect("for (f() of []);").toEvalTo(undefined);
expect(() => {
eval("for (f() of [0]) { expect().fail() }");
}).toThrowWithMessage(ReferenceError, "Invalid left-hand side in assignment");
}
);
// Does not fail since it does not iterate but prettier does not like it so we use eval.
expect("for (f() of []);").toEvalTo(undefined);
test.xfailIf(
isBytecodeInterpreterEnabled(),
"Cannot change constant declaration in body",
() => {
const vals = [];
for (const v of [1, 2]) {
expect(() => v++).toThrowWithMessage(
TypeError,
"Invalid assignment to const variable"
);
vals.push(v);
}
expect(() => {
eval("for (f() of [0]) { expect().fail() }");
}).toThrowWithMessage(ReferenceError, "Invalid left-hand side in assignment");
});
test("Cannot change constant declaration in body", () => {
const vals = [];
for (const v of [1, 2]) {
expect(() => v++).toThrowWithMessage(TypeError, "Invalid assignment to const variable");
vals.push(v);
expect(vals).toEqual([1, 2]);
}
expect(vals).toEqual([1, 2]);
});
);
});