RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:32:44 +00:00
Code Issues Activity Actions

LibWeb: Rename FormattingContext::compute_position() => compute_inset()

Browse source 
This function computes the used inset properties, not the position of a
box per se, so let's call it something more accurate.
This commit is contained in:
Andreas Kling 2022-03-27 15:35:28 +02:00
parent c49c036c84
commit d77dfc6b48
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -391,7 +391,7 @@ void BlockFormattingContext::layout_block_level_children(BlockContainer const& b
compute_height(child_box, m_state); compute_height(child_box, m_state);
compute_position(child_box); compute_inset(child_box);
if (is<ReplacedBox>(child_box) || is<BlockContainer>(child_box)) if (is<ReplacedBox>(child_box) || is<BlockContainer>(child_box))
place_block_level_element_in_normal_flow_horizontally(child_box, block_container); place_block_level_element_in_normal_flow_horizontally(child_box, block_container);

2
Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -766,7 +766,7 @@ void FormattingContext::compute_height_for_absolutely_positioned_replaced_elemen
m_state.get_mutable(box).content_height = compute_height_for_replaced_element(m_state, box); m_state.get_mutable(box).content_height = compute_height_for_replaced_element(m_state, box);
} }
void FormattingContext::compute_position(Box const& box) void FormattingContext::compute_inset(Box const& box)
{ {
// 9.4.3 Relative positioning // 9.4.3 Relative positioning
// Once a box has been laid out according to the normal flow or floated, it may be shifted relative to this position. // Once a box has been laid out according to the normal flow or floated, it may be shifted relative to this position.

2
Userland/Libraries/LibWeb/Layout/FormattingContext.h
View file

@ -65,7 +65,7 @@ protected:
FormattingState::IntrinsicSizes calculate_intrinsic_sizes(Layout::Box const&) const; FormattingState::IntrinsicSizes calculate_intrinsic_sizes(Layout::Box const&) const;
OwnPtr<FormattingContext> layout_inside(Box const&, LayoutMode); OwnPtr<FormattingContext> layout_inside(Box const&, LayoutMode);
void compute_position(Box const&); void compute_inset(Box const& box);
struct SpaceUsedByFloats { struct SpaceUsedByFloats {
float left { 0 }; float left { 0 };