RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:48:10 +00:00
Code Issues Activity Actions

Kernel: Ignore subsequent calls to Process::die

Browse source 
It's possible that another thread might try to exit the process just
about the same time another thread does the same, or a crash happens.
Also, we may not be able to kill all other threads instantly as they
may be blocked in the kernel (though in this case they would get killed
before ever returning back to user mode. So keep track of whether
Process::die was already called and ignore it on subsequent calls.

Fixes #8485
This commit is contained in:
Tom 2021-07-13 17:15:24 -06:00 • committed by Andreas Kling
parent 3cc0283eac
commit d7e5521a04
3 changed files with 25 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Syscall.cpp
View file

@ -155,6 +155,12 @@ NEVER_INLINE void syscall_handler(TrapFrame* trap)
auto current_thread = Thread::current();
VERIFY(current_thread->previous_mode() == Thread::PreviousMode::UserMode);
auto& process = current_thread->process();
if (process.is_dying()) {
// It's possible this thread is just about to make a syscall while another is
// is killing our process.
current_thread->die_if_needed();
return;
}
if (auto tracer = process.tracer(); tracer && tracer->is_tracing_syscalls()) {
tracer->set_trace_syscalls(false);