From d80c520a924186aac19b2d604ae82e6ff58134e1 Mon Sep 17 00:00:00 2001 From: thankyouverycool <66646555+thankyouverycool@users.noreply.github.com> Date: Sun, 11 Dec 2022 13:14:32 -0500 Subject: [PATCH] WindowServer: Include missing visibility argument when making MenuItem Fixes checkable MenuItems drawing incorrectly due to shifted defaults. --- Userland/Services/WindowServer/ConnectionFromClient.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Userland/Services/WindowServer/ConnectionFromClient.cpp b/Userland/Services/WindowServer/ConnectionFromClient.cpp index e34495f2f7..e2b6af808a 100644 --- a/Userland/Services/WindowServer/ConnectionFromClient.cpp +++ b/Userland/Services/WindowServer/ConnectionFromClient.cpp @@ -136,13 +136,12 @@ void ConnectionFromClient::add_menu_item(i32 menu_id, i32 identifier, i32 submen return; } auto& menu = *(*it).value; - auto menu_item = make(menu, identifier, text, shortcut, enabled, checkable, checked); + auto menu_item = make(menu, identifier, text, shortcut, enabled, visible, checkable, checked); if (is_default) menu_item->set_default(true); menu_item->set_icon(icon.bitmap()); menu_item->set_submenu_id(submenu_id); menu_item->set_exclusive(exclusive); - menu_item->set_visible(visible); menu.add_item(move(menu_item)); }