From d832f3a8871f6487cfd495522f7eec5a67e19850 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 19 Jul 2023 19:56:59 +0100 Subject: [PATCH] HackStudio+LibGUI: Remove TextDocument::is_code_document() The same thing can be accomplished with `is` and `verify_cast`, without making LibGUI care about HackStudio internals. --- Userland/DevTools/HackStudio/CodeDocument.h | 2 -- Userland/DevTools/HackStudio/Editor.cpp | 6 ++---- Userland/Libraries/LibGUI/TextDocument.h | 2 -- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Userland/DevTools/HackStudio/CodeDocument.h b/Userland/DevTools/HackStudio/CodeDocument.h index a0a2687091..045d3a5d82 100644 --- a/Userland/DevTools/HackStudio/CodeDocument.h +++ b/Userland/DevTools/HackStudio/CodeDocument.h @@ -29,8 +29,6 @@ public: DeprecatedString const& file_path() const { return m_file_path; } Optional const& language() const { return m_language; } - virtual bool is_code_document() const override final { return true; } - enum class DiffType { None, AddedLine, diff --git a/Userland/DevTools/HackStudio/Editor.cpp b/Userland/DevTools/HackStudio/Editor.cpp index a2d766f2b1..4234230fe1 100644 --- a/Userland/DevTools/HackStudio/Editor.cpp +++ b/Userland/DevTools/HackStudio/Editor.cpp @@ -456,9 +456,7 @@ Gfx::Bitmap const& Editor::current_position_icon_bitmap() CodeDocument const& Editor::code_document() const { - auto const& doc = document(); - VERIFY(doc.is_code_document()); - return static_cast(doc); + return verify_cast(document()); } CodeDocument& Editor::code_document() @@ -471,7 +469,7 @@ void Editor::set_document(GUI::TextDocument& doc) if (has_document() && &document() == &doc) return; - VERIFY(doc.is_code_document()); + VERIFY(is(doc)); GUI::TextEditor::set_document(doc); set_override_cursor(Gfx::StandardCursor::IBeam); diff --git a/Userland/Libraries/LibGUI/TextDocument.h b/Userland/Libraries/LibGUI/TextDocument.h index c381347501..8380e71bcf 100644 --- a/Userland/Libraries/LibGUI/TextDocument.h +++ b/Userland/Libraries/LibGUI/TextDocument.h @@ -150,8 +150,6 @@ public: TextPosition insert_at(TextPosition const&, StringView, Client const* = nullptr); void remove(TextRange const&); - virtual bool is_code_document() const { return false; } - bool is_empty() const; bool is_modified() const { return m_undo_stack.is_current_modified(); } void set_unmodified();