From d8357ceb2684fbf32a3a4846f7b5bc8a99ddd262 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 20 Jan 2020 22:32:44 +0100 Subject: [PATCH] SystemMonitor: Add an "Unveiled paths" section to the per-process tabs This shows the data from /proc/PID/unveil in a nice table view. :^) --- Applications/SystemMonitor/Makefile | 1 + .../ProcessUnveiledPathsWidget.cpp | 56 +++++++++++++++++++ .../ProcessUnveiledPathsWidget.h | 45 +++++++++++++++ Applications/SystemMonitor/main.cpp | 5 ++ 4 files changed, 107 insertions(+) create mode 100644 Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp create mode 100644 Applications/SystemMonitor/ProcessUnveiledPathsWidget.h diff --git a/Applications/SystemMonitor/Makefile b/Applications/SystemMonitor/Makefile index 34196422b8..392ea5b6d6 100644 --- a/Applications/SystemMonitor/Makefile +++ b/Applications/SystemMonitor/Makefile @@ -8,6 +8,7 @@ OBJS = \ ProcessMemoryMapWidget.o \ ProcessFileDescriptorMapWidget.o \ NetworkStatisticsWidget.o \ + ProcessUnveiledPathsWidget.o \ main.o PROGRAM = SystemMonitor diff --git a/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp b/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp new file mode 100644 index 0000000000..174e753469 --- /dev/null +++ b/Applications/SystemMonitor/ProcessUnveiledPathsWidget.cpp @@ -0,0 +1,56 @@ +/* + * Copyright (c) 2018-2020, Andreas Kling + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#include "ProcessUnveiledPathsWidget.h" +#include +#include +#include + +ProcessUnveiledPathsWidget::ProcessUnveiledPathsWidget(GWidget* parent) + : GWidget(parent) +{ + set_layout(make(Orientation::Vertical)); + layout()->set_margins({ 4, 4, 4, 4 }); + m_table_view = GTableView::construct(this); + m_table_view->set_size_columns_to_fit_content(true); + + Vector pid_unveil_fields; + pid_unveil_fields.empend("path", "Path", TextAlignment::CenterLeft); + pid_unveil_fields.empend("permissions", "Permissions", TextAlignment::CenterLeft); + m_table_view->set_model(GJsonArrayModel::create({}, move(pid_unveil_fields))); +} + +ProcessUnveiledPathsWidget::~ProcessUnveiledPathsWidget() +{ +} + +void ProcessUnveiledPathsWidget::set_pid(pid_t pid) +{ + if (m_pid == pid) + return; + m_pid = pid; + static_cast(m_table_view->model())->set_json_path(String::format("/proc/%d/unveil", m_pid)); +} diff --git a/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h b/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h new file mode 100644 index 0000000000..84abe4f508 --- /dev/null +++ b/Applications/SystemMonitor/ProcessUnveiledPathsWidget.h @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2018-2020, Andreas Kling + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER + * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#pragma once + +#include + +class GTableView; + +class ProcessUnveiledPathsWidget final : public GWidget { + C_OBJECT(ProcessUnveiledPathsWidget); +public: + virtual ~ProcessUnveiledPathsWidget() override; + + void set_pid(pid_t); + +private: + explicit ProcessUnveiledPathsWidget(GWidget* parent); + + RefPtr m_table_view; + pid_t m_pid { -1 }; +}; diff --git a/Applications/SystemMonitor/main.cpp b/Applications/SystemMonitor/main.cpp index 096892e50b..f715ce8b4b 100644 --- a/Applications/SystemMonitor/main.cpp +++ b/Applications/SystemMonitor/main.cpp @@ -33,6 +33,7 @@ #include "ProcessModel.h" #include "ProcessStacksWidget.h" #include "ProcessTableView.h" +#include "ProcessUnveiledPathsWidget.h" #include #include #include @@ -213,6 +214,9 @@ int main(int argc, char** argv) auto open_files_widget = ProcessFileDescriptorMapWidget::construct(nullptr); process_tab_widget->add_widget("Open files", open_files_widget); + auto unveiled_paths_widget = ProcessUnveiledPathsWidget::construct(nullptr); + process_tab_widget->add_widget("Unveiled paths", unveiled_paths_widget); + auto stacks_widget = ProcessStacksWidget::construct(nullptr); process_tab_widget->add_widget("Stacks", stacks_widget); @@ -220,6 +224,7 @@ int main(int argc, char** argv) open_files_widget->set_pid(pid); stacks_widget->set_pid(pid); memory_map_widget->set_pid(pid); + unveiled_paths_widget->set_pid(pid); }; window->show();