RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 19:27:35 +00:00
Code Issues Activity Actions

LibJS: get_iterator_values() should pass Value to callback (not Value&)

Browse source 
Value& implies that the callback is expected/able to modify the value,
which is not the case.
This commit is contained in:
Andreas Kling 2020-09-08 14:15:13 +02:00
parent b4bfc3ed54
commit d85eed585c
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/AST.cpp
View file

@ -163,7 +163,7 @@ Value CallExpression::execute(Interpreter& interpreter, GlobalObject& global_obj
if (interpreter.exception()) if (interpreter.exception())
return {}; return {};
if (m_arguments[i].is_spread) { if (m_arguments[i].is_spread) {
get_iterator_values(global_object, value, [&](Value& iterator_value) { get_iterator_values(global_object, value, [&](Value iterator_value) {
if (interpreter.exception()) if (interpreter.exception())
return IterationDecision::Break; return IterationDecision::Break;
arguments.append(iterator_value); arguments.append(iterator_value);
@ -419,7 +419,7 @@ Value ForOfStatement::execute(Interpreter& interpreter, GlobalObject& global_obj
if (interpreter.exception()) if (interpreter.exception())
return {}; return {};
get_iterator_values(global_object, rhs_result, [&](Value& value) { get_iterator_values(global_object, rhs_result, [&](Value value) {
interpreter.set_variable(variable_name, value, global_object); interpreter.set_variable(variable_name, value, global_object);
last_value = interpreter.run(global_object, *m_body); last_value = interpreter.run(global_object, *m_body);
if (interpreter.exception()) if (interpreter.exception())
@ -1652,7 +1652,7 @@ Value ArrayExpression::execute(Interpreter& interpreter, GlobalObject& global_ob
return {}; return {};
if (element->is_spread_expression()) { if (element->is_spread_expression()) {
get_iterator_values(global_object, value, [&](Value& iterator_value) { get_iterator_values(global_object, value, [&](Value iterator_value) {
array->indexed_properties().append(iterator_value); array->indexed_properties().append(iterator_value);
return IterationDecision::Continue; return IterationDecision::Continue;
}); });

2
Libraries/LibJS/Runtime/ArrayConstructor.cpp
View file

@ -108,7 +108,7 @@ JS_DEFINE_NATIVE_FUNCTION(ArrayConstructor::from)
array->set_indexed_property_elements(move(elements)); array->set_indexed_property_elements(move(elements));
} else { } else {
// * iterable objects // * iterable objects
get_iterator_values(global_object, value, [&](Value& element) { get_iterator_values(global_object, value, [&](Value element) {
if (interpreter.exception()) if (interpreter.exception())
return IterationDecision::Break; return IterationDecision::Break;
array->indexed_properties().append(element); array->indexed_properties().append(element);

2
Libraries/LibJS/Runtime/IteratorOperations.cpp
View file

@ -101,7 +101,7 @@ Value create_iterator_result_object(GlobalObject& global_object, Value value, bo
return object; return object;
} }
void get_iterator_values(GlobalObject& global_object, Value value, AK::Function<IterationDecision(Value&)> callback) void get_iterator_values(GlobalObject& global_object, Value value, AK::Function<IterationDecision(Value)> callback)
{ {
auto& interpreter = global_object.interpreter(); auto& interpreter = global_object.interpreter();

2
Libraries/LibJS/Runtime/IteratorOperations.h
View file

@ -41,6 +41,6 @@ Value create_iterator_result_object(GlobalObject&, Value value, bool done);
Object* iterator_next(Object& iterator, Value value = {}); Object* iterator_next(Object& iterator, Value value = {});
void iterator_close(Object& iterator); void iterator_close(Object& iterator);
void get_iterator_values(GlobalObject&, Value value, AK::Function<IterationDecision(Value&)> callback); void get_iterator_values(GlobalObject&, Value value, AK::Function<IterationDecision(Value)> callback);
} }