RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibVT: Always clear "stomp" state when changing the cursor position

Browse source 
This fixes a bug, where we mistakenly put a character in the next row if
the cursor was told to move to the rightmost column when it was already
there.
This commit is contained in:
Daniel Bertalan 2021-12-28 13:28:21 +01:00 • committed by Brian Gianforcaro
parent 2329c52ad9
commit d8e383edd0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibVT/Terminal.cpp
View file

@ -881,6 +881,7 @@ void Terminal::set_cursor(unsigned a_row, unsigned a_column, bool skip_debug)
{ {
unsigned row = min(a_row, m_rows - 1u); unsigned row = min(a_row, m_rows - 1u);
unsigned column = min(a_column, m_columns - 1u); unsigned column = min(a_column, m_columns - 1u);
m_stomp = false;
if (row == cursor_row() && column == cursor_column()) if (row == cursor_row() && column == cursor_column())
return; return;
VERIFY(row < rows()); VERIFY(row < rows());
@ -888,7 +889,6 @@ void Terminal::set_cursor(unsigned a_row, unsigned a_column, bool skip_debug)
invalidate_cursor(); invalidate_cursor();
m_current_state.cursor.row = row; m_current_state.cursor.row = row;
m_current_state.cursor.column = column; m_current_state.cursor.column = column;
m_stomp = false;
invalidate_cursor(); invalidate_cursor();
if (!skip_debug) if (!skip_debug)
dbgln_if(TERMINAL_DEBUG, "Set cursor position: {},{}", cursor_row(), cursor_column()); dbgln_if(TERMINAL_DEBUG, "Set cursor position: {},{}", cursor_row(), cursor_column());