RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:17:44 +00:00
Code Issues Activity Actions

LibCore: Fix UDPServer up to properly receive data

Browse source 
Prior to this, UDPServer was using listen/accept, which does not make
sense in the context of UDP.
This commit is contained in:
AnotherTest 2020-04-04 14:29:33 +04:30 • committed by Andreas Kling
parent 2ea934bcfd
commit d8e944e899
2 changed files with 27 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibCore/UDPServer.h
View file

@ -26,10 +26,12 @@
#pragma once
#include <AK/ByteBuffer.h>
#include <AK/Forward.h>
#include <AK/Function.h>
#include <LibCore/Forward.h>
#include <LibCore/Object.h>
#include <LibCore/SocketAddress.h>
namespace Core {
@ -38,21 +40,26 @@ class UDPServer : public Object {
public:
virtual ~UDPServer() override;
bool is_listening() const { return m_listening; }
bool listen(const IPv4Address& address, u16 port);
bool is_bound() const { return m_bound; }
RefPtr<UDPSocket> accept();
bool bind(const IPv4Address& address, u16 port);
ByteBuffer receive(size_t size, sockaddr_in& from);
ByteBuffer receive(size_t size)
{
struct sockaddr_in saddr;
return receive(size, saddr);
};
Optional<IPv4Address> local_address() const;
Optional<u16> local_port() const;
Function<void()> on_ready_to_accept;
Function<void()> on_ready_to_receive;
private:
explicit UDPServer(Object* parent = nullptr);
int m_fd { -1 };
bool m_listening { false };
bool m_bound { false };
RefPtr<Notifier> m_notifier;
};