RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 20:42:43 +00:00
Code Issues Activity Actions

VM: Remove PhysicalPage::create_eternal().

Browse source 
Now that it is possible to create non-eternal non-freeable
pages, PageDirectory can do just that.
This commit is contained in:
Sergey Bugaev 2019-06-14 17:10:49 +03:00 • committed by Andreas Kling
parent 010314ee66
commit d900fe98e2
3 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/VM/PageDirectory.cpp
View file

@ -9,7 +9,7 @@ static const dword kernelspace_range_base = 0xc0000000;
PageDirectory::PageDirectory(PhysicalAddress paddr) PageDirectory::PageDirectory(PhysicalAddress paddr)
: m_range_allocator(VirtualAddress(0xc0000000), 0x3f000000) : m_range_allocator(VirtualAddress(0xc0000000), 0x3f000000)
{ {
m_directory_page = PhysicalPage::create_eternal(paddr, true); m_directory_page = PhysicalPage::create(paddr, true, false);
} }
PageDirectory::PageDirectory(const RangeAllocator* parent_range_allocator) PageDirectory::PageDirectory(const RangeAllocator* parent_range_allocator)

7
Kernel/VM/PhysicalPage.cpp
View file

@ -2,13 +2,6 @@
#include <Kernel/VM/PhysicalPage.h> #include <Kernel/VM/PhysicalPage.h>
#include <Kernel/kmalloc.h> #include <Kernel/kmalloc.h>
Retained<PhysicalPage> PhysicalPage::create_eternal(PhysicalAddress paddr, bool supervisor)
{
void* slot = kmalloc_eternal(sizeof(PhysicalPage));
new (slot) PhysicalPage(paddr, supervisor, false);
return adopt(*(PhysicalPage*)slot);
}
Retained<PhysicalPage> PhysicalPage::create(PhysicalAddress paddr, bool supervisor, bool may_return_to_freelist) Retained<PhysicalPage> PhysicalPage::create(PhysicalAddress paddr, bool supervisor, bool may_return_to_freelist)
{ {
void* slot = kmalloc(sizeof(PhysicalPage)); void* slot = kmalloc(sizeof(PhysicalPage));

1
Kernel/VM/PhysicalPage.h
View file

@ -28,7 +28,6 @@ public:
} }
} }
static Retained<PhysicalPage> create_eternal(PhysicalAddress, bool supervisor);
static Retained<PhysicalPage> create(PhysicalAddress, bool supervisor, bool may_return_to_freelist = true); static Retained<PhysicalPage> create(PhysicalAddress, bool supervisor, bool may_return_to_freelist = true);
word retain_count() const { return m_retain_count; } word retain_count() const { return m_retain_count; }