RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-19 00:25:07 +00:00
Code Issues Activity Actions

Let reap() communicate the dead process's exit status to the caller.

Browse source 
This way the scheduler doesn't need to plumb the exit status into the waiter.
We still plumb the waitee pid though, I don't love it but it can be fixed.
This commit is contained in:
Andreas Kling 2018-11-28 22:01:24 +01:00
parent 938d1b8bfb
commit d90104f9e0
4 changed files with 18 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Scheduler.cpp
View file

@ -39,7 +39,6 @@ bool Scheduler::pick_next()
if (child.state() != Process::Dead)
return true;
if (process.waitee() == -1 || process.waitee() == child.pid()) {
process.m_waitee_status = (child.m_termination_status << 8) | child.m_termination_signal;
process.m_waitee = child.pid();
process.unblock();
return false;
@ -75,8 +74,12 @@ bool Scheduler::pick_next()
}
if (process.state() == Process::Dead) {
if (current != &process && !Process::from_pid(process.ppid()))
Process::reap(process);
if (current != &process && !Process::from_pid(process.ppid())) {
auto name = process.name();
auto pid = process.pid();
auto exit_status = Process::reap(process);
kprintf("reaped unparented process %s(%u), exit status: %u\n", name.characters(), pid, exit_status);
}
return true;
}